Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2163533002: Downgrade Mac GN arg save_unstripped_output to just a variable. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, Mark Mentovai, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Downgrade Mac GN arg save_unstripped_output to just a variable. It's not clear that we really need the GN arg `save_unstripped_output` to be a user-configurable thing, so this change removes it from the declare_arg() block in the build file and instead becomes a shorthand for (enable_stripping && !enable_dsyms). R=rsesek@chromium.org BUG=623685, 628052 Committed: https://crrev.com/1b53b935fb9febdbc52456d8643b02a39c83b737 Cr-Commit-Position: refs/heads/master@{#406338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M build/config/mac/symbols.gni View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Dirk Pranke
4 years, 5 months ago (2016-07-19 00:12:52 UTC) #1
Dirk Pranke
I don't fell that strongly about it not being a declare_arg(), but it seems like ...
4 years, 5 months ago (2016-07-19 00:13:36 UTC) #3
Robert Sesek
LGTM
4 years, 5 months ago (2016-07-19 14:13:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163533002/1
4 years, 5 months ago (2016-07-19 17:59:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 19:17:06 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 19:20:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b53b935fb9febdbc52456d8643b02a39c83b737
Cr-Commit-Position: refs/heads/master@{#406338}

Powered by Google App Engine
This is Rietveld 408576698