Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: build/config/mac/symbols.gni

Issue 2163533002: Downgrade Mac GN arg save_unstripped_output to just a variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/symbols.gni
diff --git a/build/config/mac/symbols.gni b/build/config/mac/symbols.gni
index b54003a2b3f445cefab7c519c1782baea1364125..8cec6955dcebda06218744ff7abd49eb3ac36db1 100644
--- a/build/config/mac/symbols.gni
+++ b/build/config/mac/symbols.gni
@@ -21,13 +21,9 @@ declare_args() {
# linked target and apply custom -Wcrl,strip flags. See
# //build/toolchain/mac/linker_driver.py for more information.
enable_stripping = is_official_build
-
- # Save unstripped copies of targets with a ".unstripped" suffix. This is
- # useful to preserve the original output when enable_stripping=true.
- save_unstripped_output = false
}
-if (save_unstripped_output) {
- assert(enable_stripping,
- "save_unstripped_output=true requires enable_stripping=true")
-}
+# Save unstripped copies of targets with a ".unstripped" suffix. This is
+# useful to preserve the original output when enable_stripping=true but
+# we're not actually generating real dSYMs.
+save_unstripped_output = enable_stripping && !enable_dsyms
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698