Break glScheduleCALayerCHROMIUM into smaller functions.

Break glScheduleCALayerCHROMIUM into smaller functions.

This CL is a refactor and has no intended behavior changes.

Consecutive CALayerOverlays frequently share a lot of state. Create a new
function glScheduleCALayerSharedStateCHROMIUM to pass this shared state.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/17aefc360b0f73be31b1a6dfafb87782972f8dde
Cr-Commit-Position: refs/heads/master@{#406406}

[erikchen, 2016-07-18 23:15:55]

Description was changed from

==========
Add new command decoder function.

BUG=
==========

to

==========
Add new command decoder function.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-07-18 23:15:56]

Description was changed from

==========
Add new command decoder function.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add new command decoder function.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-07-19 00:17:28]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 00:18:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 00:21:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 00:21:59]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-07-19 00:30:45]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-07-19 00:32:50]

Description was changed from

==========
Add new command decoder function.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Break glScheduleCALayerCHROMIUM into smaller functions.

This CL is a refactor and has no intended behavior changes.

Consecutive CALayerOverlays frequently share a lot of state. Create new
functions glScheduleCALayerSharedStateCHROMIUM and
glUnscheduleCALayerSharedStateCHROMIUM() to pass this shared state.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-19 00:33:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 01:54:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 01:54:27]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-07-19 06:16:43]

Description was changed from

==========
Break glScheduleCALayerCHROMIUM into smaller functions.

This CL is a refactor and has no intended behavior changes.

Consecutive CALayerOverlays frequently share a lot of state. Create new
functions glScheduleCALayerSharedStateCHROMIUM and
glUnscheduleCALayerSharedStateCHROMIUM() to pass this shared state.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Break glScheduleCALayerCHROMIUM into smaller functions.

This CL is a refactor and has no intended behavior changes.

Consecutive CALayerOverlays frequently share a lot of state. Create new
functions glScheduleCALayerSharedStateCHROMIUM and
glUnscheduleCALayerSharedStateCHROMIUM() to pass this shared state.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-07-19 06:17:04]

erikchen@chromium.org changed reviewers:
+ ccameron@chromium.org

[erikchen, 2016-07-19 06:17:04]

ccameron: Please review.

[ccameron, 2016-07-19 20:29:51]

lg, but I'd really prefer not to have the "unschedule" -- the scheduling stuff
is really statefully-tied to swap, so we might as well reinforce it

https://codereview.chromium.org/2163493002/diff/40001/gpu/GLES2/extensions/CH...
File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt (right):

https://codereview.chromium.org/2163493002/diff/40001/gpu/GLES2/extensions/CH...
gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt:62: 
Let's just have SwapBuffers automatically clear the shared state, rather than
having an explicit "unschedule". We already latch everything at swap, so it's
pretty consistent.

[erikchen, 2016-07-19 20:41:45]

Description was changed from

==========
Break glScheduleCALayerCHROMIUM into smaller functions.

This CL is a refactor and has no intended behavior changes.

Consecutive CALayerOverlays frequently share a lot of state. Create new
functions glScheduleCALayerSharedStateCHROMIUM and
glUnscheduleCALayerSharedStateCHROMIUM() to pass this shared state.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Break glScheduleCALayerCHROMIUM into smaller functions.

This CL is a refactor and has no intended behavior changes.

Consecutive CALayerOverlays frequently share a lot of state. Create a new
function glScheduleCALayerSharedStateCHROMIUM to pass this shared state.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-07-19 20:41:57]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-07-19 20:42:26]

ccameron: PTAL

https://codereview.chromium.org/2163493002/diff/40001/gpu/GLES2/extensions/CH...
File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt (right):

https://codereview.chromium.org/2163493002/diff/40001/gpu/GLES2/extensions/CH...
gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_ca_layer.txt:62: 
On 2016/07/19 20:29:51, ccameron wrote:
> Let's just have SwapBuffers automatically clear the shared state, rather than
> having an explicit "unschedule". We already latch everything at swap, so it's
> pretty consistent.

Done.

[commit-bot: I haz the power, 2016-07-19 20:42:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-07-19 20:45:32]

That was fast. lgtm

Leaving checking the middle encode/decode logic to a gpu/ OWNER.

[erikchen, 2016-07-19 20:47:31]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org

[erikchen, 2016-07-19 20:47:32]

piman: Please review.

[piman, 2016-07-19 20:56:46]

lgtm

https://codereview.chromium.org/2163493002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2163493002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:10786: GL_INVALID_VALUE,
"glScheduleCALayerCHROMIUM",
nit: commonly GL_INVALID_OPERATION is the error raised when there is a state
inconsistency between multiple calls.

Either way, could you mention this in the extension text?

https://codereview.chromium.org/2163493002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13755:
ca_layer_shared_state_.reset();
nit: can you also add this to HandlePostSubBufferCHROMIUM and
DoCommitOverlayPlanes?

[erikchen, 2016-07-19 21:40:22]

https://codereview.chromium.org/2163493002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2163493002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:10786: GL_INVALID_VALUE,
"glScheduleCALayerCHROMIUM",
On 2016/07/19 20:56:46, piman wrote:
> nit: commonly GL_INVALID_OPERATION is the error raised when there is a state
> inconsistency between multiple calls.
> 
> Either way, could you mention this in the extension text?

Done.

https://codereview.chromium.org/2163493002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:13755:
ca_layer_shared_state_.reset();
On 2016/07/19 20:56:46, piman wrote:
> nit: can you also add this to HandlePostSubBufferCHROMIUM and
> DoCommitOverlayPlanes?

Done.

[erikchen, 2016-07-19 21:40:27]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-07-19 21:40:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2163493002/#ps80001
(title: "Comments from piman.")

[commit-bot: I haz the power, 2016-07-19 21:41:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 23:04:02]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-19 23:05:51]

Description was changed from

==========
Break glScheduleCALayerCHROMIUM into smaller functions.

This CL is a refactor and has no intended behavior changes.

Consecutive CALayerOverlays frequently share a lot of state. Create a new
function glScheduleCALayerSharedStateCHROMIUM to pass this shared state.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Break glScheduleCALayerCHROMIUM into smaller functions.

This CL is a refactor and has no intended behavior changes.

Consecutive CALayerOverlays frequently share a lot of state. Create a new
function glScheduleCALayerSharedStateCHROMIUM to pass this shared state.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/17aefc360b0f73be31b1a6dfafb87782972f8dde
Cr-Commit-Position: refs/heads/master@{#406406}
==========

[commit-bot: I haz the power, 2016-07-19 23:05:52]

Patchset 5 (id:??) landed as
https://crrev.com/17aefc360b0f73be31b1a6dfafb87782972f8dde
Cr-Commit-Position: refs/heads/master@{#406406}