Refactor CALayerOverlay to pull out CALayerOverlaySharedState.

Refactor CALayerOverlay to pull out CALayerOverlaySharedState.

This CL is a refactor and has no intended behavior change.

Consecutive CALayerOverlays frequently share state, just like consecutive
DrawQuads. This CL creates a new class CALayerOverlaySharedState to hold that
shared state. This is in preparation for a simplification of
ScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e466cb7bf97a2ee5c9701257b00020484f37bf4a
Cr-Commit-Position: refs/heads/master@{#406195}

[erikchen, 2016-07-18 21:53:49]

Description was changed from

==========
Refactor CALayerOverlay to pull out CALayerOverlaySharedState.

This CL is a refactor and has no intended behavior change.

Consecutive CALayerOverlays frequently share state, just like consecutive
DrawQuads. This CL creates a new class CALayerOverlaySharedState to hold that
shared state. This is in preparation for a clean up of ScheduleCALayerCHROMIUM.

BUG=581526
==========

to

==========
Refactor CALayerOverlay to pull out CALayerOverlaySharedState.

This CL is a refactor and has no intended behavior change.

Consecutive CALayerOverlays frequently share state, just like consecutive
DrawQuads. This CL creates a new class CALayerOverlaySharedState to hold that
shared state. This is in preparation for a clean up of ScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-07-18 21:53:58]

Description was changed from

==========
Refactor CALayerOverlay to pull out CALayerOverlaySharedState.

This CL is a refactor and has no intended behavior change.

Consecutive CALayerOverlays frequently share state, just like consecutive
DrawQuads. This CL creates a new class CALayerOverlaySharedState to hold that
shared state. This is in preparation for a clean up of ScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Refactor CALayerOverlay to pull out CALayerOverlaySharedState.

This CL is a refactor and has no intended behavior change.

Consecutive CALayerOverlays frequently share state, just like consecutive
DrawQuads. This CL creates a new class CALayerOverlaySharedState to hold that
shared state. This is in preparation for a simplification of
ScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[erikchen, 2016-07-18 21:54:46]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-07-18 21:54:55]

erikchen@chromium.org changed reviewers:
+ ccameron@chromium.org

[erikchen, 2016-07-18 21:54:56]

ccameron: Please review.

[commit-bot: I haz the power, 2016-07-18 21:55:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 22:05:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 22:05:38]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ccameron, 2016-07-18 22:56:57]

lgtm, though there are some issues with unit tests that need cleaning up

https://codereview.chromium.org/2156913003/diff/1/cc/output/ca_layer_overlay.cc
File cc/output/ca_layer_overlay.cc (right):

https://codereview.chromium.org/2156913003/diff/1/cc/output/ca_layer_overlay....
cc/output/ca_layer_overlay.cc:210: CALayerOverlayProcessor processor;
Maybe roll resource provider and display rect into CALayerOverlayProcessor, too?
And have the handful of functions that take the resource_provider be members,
instead of passing the same arguments around.

Maybe for later, if you'd prefer the smaller patch.

[erikchen, 2016-07-18 23:16:14]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 23:16:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 23:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 23:34:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-07-19 00:15:27]

https://codereview.chromium.org/2156913003/diff/1/cc/output/ca_layer_overlay.cc
File cc/output/ca_layer_overlay.cc (right):

https://codereview.chromium.org/2156913003/diff/1/cc/output/ca_layer_overlay....
cc/output/ca_layer_overlay.cc:210: CALayerOverlayProcessor processor;
On 2016/07/18 22:56:57, ccameron wrote:
> Maybe roll resource provider and display rect into CALayerOverlayProcessor,
too?
> And have the handful of functions that take the resource_provider be members,
> instead of passing the same arguments around.
> 
> Maybe for later, if you'd prefer the smaller patch.

Good suggestion, maybe in a future CL?

[erikchen, 2016-07-19 00:15:30]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-07-19 00:15:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2156913003/#ps20001
(title: "Fix tests.")

[commit-bot: I haz the power, 2016-07-19 00:16:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 00:20:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 00:20:06]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[erikchen, 2016-07-19 00:25:44]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-07-19 00:25:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/2156913003/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-19 00:26:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 02:48:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-19 02:48:14]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 02:50:02]

Description was changed from

==========
Refactor CALayerOverlay to pull out CALayerOverlaySharedState.

This CL is a refactor and has no intended behavior change.

Consecutive CALayerOverlays frequently share state, just like consecutive
DrawQuads. This CL creates a new class CALayerOverlaySharedState to hold that
shared state. This is in preparation for a simplification of
ScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
Refactor CALayerOverlay to pull out CALayerOverlaySharedState.

This CL is a refactor and has no intended behavior change.

Consecutive CALayerOverlays frequently share state, just like consecutive
DrawQuads. This CL creates a new class CALayerOverlaySharedState to hold that
shared state. This is in preparation for a simplification of
ScheduleCALayerCHROMIUM.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e466cb7bf97a2ee5c9701257b00020484f37bf4a
Cr-Commit-Position: refs/heads/master@{#406195}
==========

[commit-bot: I haz the power, 2016-07-19 02:50:03]

Patchset 3 (id:??) landed as
https://crrev.com/e466cb7bf97a2ee5c9701257b00020484f37bf4a
Cr-Commit-Position: refs/heads/master@{#406195}