Adding color space to SkSpecialImage

Adding color space to SkSpecialImage

Mostly means that GPU backed special images need to be supplied (and
store) a color space object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163343002

Committed: https://skia.googlesource.com/skia/+/afbf71dd924c7bb46ccdac49e7408b4b088563ff

[Brian Osman, 2016-07-20 18:56:47]

Description was changed from

==========
Adding color space to SkSpecialImage

Mostly means that GPU backed special images need to be supplied (and
store) a color space object.

BUG=skia:
==========

to

==========
Adding color space to SkSpecialImage

Mostly means that GPU backed special images need to be supplied (and
store) a color space object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163343002
==========

[Brian Osman, 2016-07-20 19:15:40]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 19:15:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-07-20 19:16:00]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com, robertphillips@google.com

[Brian Osman, 2016-07-20 19:16:02]

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkBlurImageFilt...
File src/effects/SkBlurImageFilter.cpp (right):

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkBlurImageFilt...
src/effects/SkBlurImageFilter.cpp:137: drawContext->asTexture(),
Once we have color space on GrDrawContext, this should really be coming from
there (although it will be the same object, because the draw context is going to
be constructed with the color space from the source). Same comment applied to
all the other image filters below...

https://codereview.chromium.org/2163343002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/2163343002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:1474: sk_ref_sp(ii.colorSpace()),
This is still questionable, because the device's image info is still somewhat
lossy. Once we have the color space on draw context, I think this will
(automatically) become correct.

[commit-bot: I haz the power, 2016-07-20 19:35:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:35:51]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-07-20 19:44:39]

https://codereview.chromium.org/2163343002/diff/1/src/core/SkImageFilter.cpp
File src/core/SkImageFilter.cpp (right):

https://codereview.chromium.org/2163343002/diff/1/src/core/SkImageFilter.cpp#...
src/core/SkImageFilter.cpp:296: 
// TODO: get the colorSpace from the drawContext (once it has one)

?

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkBlurImageFilt...
File src/effects/SkBlurImageFilter.cpp (right):

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkBlurImageFilt...
src/effects/SkBlurImageFilter.cpp:134: 
// TODO: get the colorSpace from the drawContext (once it has one)

?

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkBlurImageFilt...
src/effects/SkBlurImageFilter.cpp:137: drawContext->asTexture(),
source -> input here

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkDisplacementM...
File src/effects/SkDisplacementMapEffect.cpp (right):

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkDisplacementM...
src/effects/SkDisplacementMapEffect.cpp:348: offset->fY = bounds.top();
// TODO: ...

?

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkLightingImage...
File src/effects/SkLightingImageFilter.cpp (right):

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:455: 
// TODO: ...

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkMorphologyIma...
File src/effects/SkMorphologyImageFilter.cpp (right):

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkMorphologyIma...
src/effects/SkMorphologyImageFilter.cpp:521: 
// TODO: ...

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkXfermodeImage...
File src/effects/SkXfermodeImageFilter.cpp (right):

https://codereview.chromium.org/2163343002/diff/1/src/effects/SkXfermodeImage...
src/effects/SkXfermodeImageFilter.cpp:254: 
// TODO: ...

https://codereview.chromium.org/2163343002/diff/1/tests/SpecialImageTest.cpp
File tests/SpecialImageTest.cpp (right):

https://codereview.chromium.org/2163343002/diff/1/tests/SpecialImageTest.cpp#...
tests/SpecialImageTest.cpp:110: 
Seems like these is some stuff we need to add here ...

[robertphillips, 2016-07-20 21:41:59]

lgtm

[Brian Osman, 2016-07-21 13:10:27]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 13:10:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 13:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 13:13:27]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[Brian Osman, 2016-07-21 13:24:44]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 13:24:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 13:41:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 13:41:48]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-07-21 13:47:33]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-07-21 13:47:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2163343002/#ps60001
(title: "Fix compile after rebase")

[commit-bot: I haz the power, 2016-07-21 13:47:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 13:49:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 13:49:28]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[Brian Osman, 2016-07-21 13:54:06]

PTAL, bsalomon@ ("public" API change is just signature of DrawWithFP)

[bsalomon, 2016-07-21 14:14:20]

On 2016/07/21 13:54:06, Brian Osman wrote:
> PTAL, bsalomon@ ("public" API change is just signature of DrawWithFP)

lgtm

[Brian Osman, 2016-07-21 14:14:32]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-07-21 14:14:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 14:15:40]

Description was changed from

==========
Adding color space to SkSpecialImage

Mostly means that GPU backed special images need to be supplied (and
store) a color space object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163343002
==========

to

==========
Adding color space to SkSpecialImage

Mostly means that GPU backed special images need to be supplied (and
store) a color space object.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163343002

Committed:
https://skia.googlesource.com/skia/+/afbf71dd924c7bb46ccdac49e7408b4b088563ff
==========

[commit-bot: I haz the power, 2016-07-21 14:15:41]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/afbf71dd924c7bb46ccdac49e7408b4b088563ff