src/effects/SkDisplacementMapEffect.cpp - Issue 2163343002: Adding color space to SkSpecialImage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkDisplacementMapEffect.cpp

Issue 2163343002: Adding color space to SkSpecialImage (Closed) Base URL: https://skia.googlesource.com/skia.git@colorspace-on-image

Patch Set: Fix compile after rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkDisplacementMapEffect.cpp

diff --git a/src/effects/SkDisplacementMapEffect.cpp b/src/effects/SkDisplacementMapEffect.cpp

index 29ce3fef524c60e9e9c6c635218b64fc6ccfd93b..392ac43cceaa7c8cd956fb53f56b79ed25cc958c 100644

--- a/src/effects/SkDisplacementMapEffect.cpp

+++ b/src/effects/SkDisplacementMapEffect.cpp

@@ -346,9 +346,11 @@ sk_sp<SkSpecialImage> SkDisplacementMapEffect::onFilterImage(SkSpecialImage* sou

offset->fX = bounds.left();

offset->fY = bounds.top();

+ // TODO: Get the colorSpace from the drawContext (once it has one)

return SkSpecialImage::MakeFromGpu(SkIRect::MakeWH(bounds.width(), bounds.height()),

kNeedNewImageUniqueID_SpecialImage,

- drawContext->asTexture());

+ drawContext->asTexture(),

+ sk_ref_sp(source->getColorSpace()));

}

#endif

« no previous file with comments | « src/effects/SkBlurImageFilter.cpp ('k') | src/effects/SkLightingImageFilter.cpp » ('j') | no next file with comments »