Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2163223004: ash: Remove WindowState::top_row_keys_are_function_keys. (Closed)

Created:
4 years, 5 months ago by sadrul
Modified:
4 years, 5 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Remove WindowState::top_row_keys_are_function_keys. This code has been dead since 2014 when its only use was removed (crrev.com/251421). So remove the code. BUG=none Committed: https://crrev.com/ca0e99985267e771ef30ae24ab5c58a35beb8aa3 Cr-Commit-Position: refs/heads/master@{#406703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -32 lines) Patch
M ash/common/wm/window_state.h View 2 chunks +0 lines, -10 lines 0 comments Download
M ash/common/wm/window_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sadrul
4 years, 5 months ago (2016-07-20 22:21:51 UTC) #6
Daniel Erat
lgtm
4 years, 5 months ago (2016-07-20 22:23:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163223004/1
4 years, 5 months ago (2016-07-20 22:51:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 22:56:12 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 22:57:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca0e99985267e771ef30ae24ab5c58a35beb8aa3
Cr-Commit-Position: refs/heads/master@{#406703}

Powered by Google App Engine
This is Rietveld 408576698