Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Unified Diff: chrome/browser/chromeos/events/event_rewriter_unittest.cc

Issue 2163223004: ash: Remove WindowState::top_row_keys_are_function_keys. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/events/event_rewriter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/events/event_rewriter_unittest.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter_unittest.cc b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
index 9d8a1d82daf13412c4dd6f776485e99c4c9237a4..a4ed9395059cbeea75b83f45ad49fbd3c1664a2f 100644
--- a/chrome/browser/chromeos/events/event_rewriter_unittest.cc
+++ b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
@@ -1996,25 +1996,12 @@ TEST_F(EventRewriterAshTest, TopRowKeysAreFunctionKeys) {
ui::KeyEvent press_f1(ui::ET_KEY_PRESSED, ui::VKEY_F1, ui::DomCode::F1,
ui::EF_NONE, ui::DomKey::F1, ui::EventTimeForNow());
- // Simulate an apps v2 window that has requested top row keys as function
- // keys. The event should not be rewritten.
- window_state->set_top_row_keys_are_function_keys(true);
- ui::EventDispatchDetails details = Send(&press_f1);
- ASSERT_FALSE(details.dispatcher_destroyed);
- PopEvents(&events);
- EXPECT_EQ(1u, events.size());
- EXPECT_EQ(
- GetExpectedResultAsString(ui::ET_KEY_PRESSED, ui::VKEY_F1,
- ui::DomCode::F1, ui::EF_NONE, ui::DomKey::F1),
- GetKeyEventAsString(*static_cast<ui::KeyEvent*>(events[0])));
-
// The event should also not be rewritten if the send-function-keys pref is
// additionally set, for both apps v2 and regular windows.
BooleanPrefMember send_function_keys_pref;
send_function_keys_pref.Init(prefs::kLanguageSendFunctionKeys, prefs());
send_function_keys_pref.SetValue(true);
- window_state->set_top_row_keys_are_function_keys(false);
- details = Send(&press_f1);
+ ui::EventDispatchDetails details = Send(&press_f1);
ASSERT_FALSE(details.dispatcher_destroyed);
PopEvents(&events);
EXPECT_EQ(1u, events.size());
« no previous file with comments | « chrome/browser/chromeos/events/event_rewriter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698