[IndexedDB] Add Observer Tests

[IndexedDB] Add Observer Tests

These tests include testing for recording operations and removal on a single database 

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference: https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934

[palakj1, 2016-07-21 03:29:56]

palakj@google.com changed reviewers:
+ cmumford@chromium.org, dmurph@chromium.org

[palakj1, 2016-07-21 03:29:57]

Please note that 'delete' option for IDBObservationType does not work correctly.
Replacing it with kDelete temporarily. Shall try to fix that soon.

These tests are not exhaustive.
They do not cover operations by worker context and on multiple databases.

[palakj1, 2016-07-21 03:31:31]

Description was changed from

==========
[IndexedDB] Observer Tests

BUG=609934
==========

to

==========
[IndexedDB] Observer Tests

* These tests include testing for recording operations and removal on a single
database 


BUG=609934
==========

[palakj1, 2016-07-21 03:32:00]

Description was changed from

==========
[IndexedDB] Observer Tests

* These tests include testing for recording operations and removal on a single
database 


BUG=609934
==========

to

==========
[IndexedDB] Observer Tests

* These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: http://goo.gl/r0eUpe

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========

[haraken, 2016-07-21 08:36:43]

modules/ LGTM

(I want to have IDB folks take a look at the change though.)

[palakj1, 2016-07-21 08:44:27]

The CQ bit was checked by palakj@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 08:44:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 08:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 08:49:56]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[cmumford, 2016-07-21 15:00:56]

Also, some changes to the summary/description:

1. The http://goo.gl/r0eUpe is an internal doc, so don't include it in the
description.
2. Maybe enhance the subject a bit, something like "[IndexedDB]: Add observer
tests".
3. You have a bullet list (asterisk), but only one item. Suggest removing the
list.

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/storage/indexeddb/resources/generic-idb-operations.js
(right):

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/generic-idb-operations.js:16:
for (j in expected_obsv)
var before "j"

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/generic-idb-operations.js:54:
var openRequest = indexedDB.open(dbname);
Add onerror handlers in these functions as well.

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/generic-idb-operations.js:55:
openRequest.onsuccess = function(){
space before brace.

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/generic-idb-operations.js:62:
console.log(tx+' '+ Object.keys(records))
space around +

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/generic-idb-operations.js:64:
tx.oncomplete = function(){
space.

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-changes.js
(right):

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-changes.js:39:
openRequest.onsuccess = t.step_func(function() {
Add onerror to avoid having to wait for test to timeout.

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-changes.js:78:
createDatabase(openRequest.result, ['store']);
I know |createDatabase| landed in a prior CL, but it has an odd name. It doesn't
actually create a database. Maybe "createObjectStores" or "createStores".

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-removal.js
(right):

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/observer-removal.js:14:
openRequest.onsuccess = t.step_func(function() {
Add onerror.

[palakj1, 2016-07-21 18:31:20]

Description was changed from

==========
[IndexedDB] Observer Tests

* These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: http://goo.gl/r0eUpe

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========

to

==========
[IndexedDB] Observer Tests

* These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========

[palakj1, 2016-07-21 18:31:20]

palakj@google.com changed reviewers:
+ haraken@chromium.org

[palakj1, 2016-07-21 18:31:38]

Description was changed from

==========
[IndexedDB] Observer Tests

* These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========

to

==========
[IndexedDB] Observer Tests

These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========

[palakj1, 2016-07-21 20:56:46]

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/storage/indexeddb/resources/generic-idb-operations.js
(right):

https://codereview.chromium.org/2163213006/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/storage/indexeddb/resources/generic-idb-operations.js:16:
for (j in expected_obsv)
On 2016/07/21 at 15:00:55, cmumford wrote:
> var before "j"

done

[palakj1, 2016-07-21 20:58:20]

Description was changed from

==========
[IndexedDB] Observer Tests

These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/dmurph/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========

to

==========
[IndexedDB] Observer Tests

These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========

[palakj1, 2016-07-21 20:58:28]

The CQ bit was checked by palakj@google.com to run a CQ dry run

[palakj1, 2016-07-21 20:58:42]

Description was changed from

==========
[IndexedDB] Observer Tests

These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========

to

==========
[IndexedDB] Add Observer Tests

These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========

[commit-bot: I haz the power, 2016-07-21 20:59:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 22:20:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 22:20:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[cmumford, 2016-07-21 23:54:44]

lgtm

[dmurph, 2016-10-25 00:04:43]

Description was changed from

==========
[IndexedDB] Add Observer Tests

These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========

to

==========
[IndexedDB] Add Observer Tests

These tests include testing for recording operations and removal on a single
database 

Current Implementation and Future Scope: https://goo.gl/Y2dobn

Reference:
https://github.com/WICG/indexed-db-observers/blob/gh-pages/EXPLAINER.md


BUG=609934
==========