third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp - Issue 2163213006: [IndexedDB] Add Observer Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

Issue 2163213006: [IndexedDB] Add Observer Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@changes_renderer

Patch Set: Post cmumford review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

index 3bb7489fe107059454df462d744bf437e277e340..e31fe235210a62be8c8441b63d58f07f80db0dd5 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp

@@ -29,7 +29,6 @@ IDBObserver::IDBObserver(IDBObserverCallback& callback, const IDBObserverInit& o

, m_values(options.values())

, m_noRecords(options.noRecords())

{

- // TODO(palakj): Throw an exception if unknown operation type.

DCHECK_EQ(m_operationTypes.size(), static_cast<size_t>(WebIDBOperationTypeCount));

m_operationTypes.reset();

m_operationTypes[WebIDBAdd] = options.operationTypes().contains(IndexedDBNames::add);