Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2163173005: Add integer array uniforms to GL and Vulkan (Closed)

Created:
4 years, 5 months ago by fmenozzi
Modified:
4 years, 5 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add integer array uniforms to GL and Vulkan BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2163173005 Committed: https://skia.googlesource.com/skia/+/35a98c733fb69ab72623cfd62ee2ac9859b0c613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M src/gpu/gl/GrGLProgramDataManager.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramDataManager.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateDataManager.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateDataManager.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fmenozzi
Needed for passing more than one atlas coordinate at a time. ptal
4 years, 5 months ago (2016-07-20 13:54:57 UTC) #3
bsalomon
lgtm, leaving vk to Greg
4 years, 5 months ago (2016-07-20 14:35:56 UTC) #4
egdaniel
lgtm
4 years, 5 months ago (2016-07-20 14:43:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163173005/1
4 years, 5 months ago (2016-07-20 14:44:20 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 15:26:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/35a98c733fb69ab72623cfd62ee2ac9859b0c613

Powered by Google App Engine
This is Rietveld 408576698