Remove DebugRedFill

Remove DebugRedFill

We already have similar mechanism in cc. Blink-side DebugRedFill also
brings complexities about display item list and paint property tree.

Committed: https://crrev.com/cc6064a85626192b850efced9be87d341e9de916
Cr-Commit-Position: refs/heads/master@{#407069}

[Xianzhu, 2016-07-20 00:24:21]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-07-20 00:32:13]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-20 00:32:13]

lgtm

[commit-bot: I haz the power, 2016-07-20 00:32:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 00:32:50]

This CL has an open dependency (Issue 2116693002 Patch 180001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Xianzhu, 2016-07-20 03:11:31]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-07-20 03:12:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 04:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 04:34:43]

Failed to apply patch for third_party/WebKit/Source/core/frame/FrameView.cpp:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/frame/FrameView.cpp:2639
  Falling back to three-way merge...
  Applied patch to 'third_party/WebKit/Source/core/frame/FrameView.cpp' with
conflicts.
  U third_party/WebKit/Source/core/frame/FrameView.cpp

Patch:       third_party/WebKit/Source/core/frame/FrameView.cpp
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp
b/third_party/WebKit/Source/core/frame/FrameView.cpp
index
687b58d8451b0789bb81f5d439dc29cfbdc80004..ae1342c015da61079e5fed989144431770cf8b2d
100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -2639,20 +2639,8 @@ void FrameView::synchronizedPaint()
 
 void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer)
 {
-    if (graphicsLayer->drawsContent()) {
-        // Usually this is not needed because the PaintLayer will setup the
chunk properties
-        // altogether. However in debug builds the GraphicsLayer could paint
debug background before
-        // we ever reach the PaintLayer.
-        Optional<ScopedPaintChunkProperties> scopedPaintChunkProperties;
-        if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
-            PaintChunkProperties properties;
-            properties.transform = m_rootTransform;
-            properties.clip = m_rootClip;
-            properties.effect = m_rootEffect;
-           
scopedPaintChunkProperties.emplace(graphicsLayer->getPaintController(),
*layoutView(), DisplayItem::DebugRedFill, properties);
-        }
+    if (graphicsLayer->drawsContent())
         graphicsLayer->paint(nullptr);
-    }
 
     if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
         if (GraphicsLayer* maskLayer = graphicsLayer->maskLayer())

[pdr., 2016-07-20 18:16:43]

Woohoo!

LGTM

[Xianzhu, 2016-07-22 03:51:53]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-07-22 03:52:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 05:16:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-22 05:20:03]

Description was changed from

==========
Remove DebugRedFill

We already have similar mechanism in cc. Blink-side DebugRedFill also
brings complexities about display item list and paint property tree.
==========

to

==========
Remove DebugRedFill

We already have similar mechanism in cc. Blink-side DebugRedFill also
brings complexities about display item list and paint property tree.

Committed: https://crrev.com/cc6064a85626192b850efced9be87d341e9de916
Cr-Commit-Position: refs/heads/master@{#407069}
==========

[commit-bot: I haz the power, 2016-07-22 05:20:04]

Patchset 1 (id:??) landed as
https://crrev.com/cc6064a85626192b850efced9be87d341e9de916
Cr-Commit-Position: refs/heads/master@{#407069}