Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2163113002: Remove DebugRedFill (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ChunkId
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2621 matching lines...) Expand 10 before | Expand all | Expand 10 after
2632 forAllNonThrottledFrameViews([](FrameView& frameView) { 2632 forAllNonThrottledFrameViews([](FrameView& frameView) {
2633 frameView.lifecycle().advanceTo(DocumentLifecycle::PaintClean); 2633 frameView.lifecycle().advanceTo(DocumentLifecycle::PaintClean);
2634 LayoutViewItem layoutViewItem = frameView.layoutViewItem(); 2634 LayoutViewItem layoutViewItem = frameView.layoutViewItem();
2635 if (!layoutViewItem.isNull()) 2635 if (!layoutViewItem.isNull())
2636 layoutViewItem.layer()->clearNeedsRepaintRecursively(); 2636 layoutViewItem.layer()->clearNeedsRepaintRecursively();
2637 }); 2637 });
2638 } 2638 }
2639 2639
2640 void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer) 2640 void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer)
2641 { 2641 {
2642 if (graphicsLayer->drawsContent()) { 2642 if (graphicsLayer->drawsContent())
2643 // Usually this is not needed because the PaintLayer will setup the chun k properties
2644 // altogether. However in debug builds the GraphicsLayer could paint deb ug background before
2645 // we ever reach the PaintLayer.
2646 Optional<ScopedPaintChunkProperties> scopedPaintChunkProperties;
2647 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
2648 PaintChunkProperties properties;
2649 properties.transform = m_rootTransform;
2650 properties.clip = m_rootClip;
2651 properties.effect = m_rootEffect;
2652 scopedPaintChunkProperties.emplace(graphicsLayer->getPaintController (), *layoutView(), DisplayItem::DebugRedFill, properties);
2653 }
2654 graphicsLayer->paint(nullptr); 2643 graphicsLayer->paint(nullptr);
2655 }
2656 2644
2657 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 2645 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
2658 if (GraphicsLayer* maskLayer = graphicsLayer->maskLayer()) 2646 if (GraphicsLayer* maskLayer = graphicsLayer->maskLayer())
2659 synchronizedPaintRecursively(maskLayer); 2647 synchronizedPaintRecursively(maskLayer);
2660 if (GraphicsLayer* contentsClippingMaskLayer = graphicsLayer->contentsCl ippingMaskLayer()) 2648 if (GraphicsLayer* contentsClippingMaskLayer = graphicsLayer->contentsCl ippingMaskLayer())
2661 synchronizedPaintRecursively(contentsClippingMaskLayer); 2649 synchronizedPaintRecursively(contentsClippingMaskLayer);
2662 if (GraphicsLayer* replicaLayer = graphicsLayer->replicaLayer()) 2650 if (GraphicsLayer* replicaLayer = graphicsLayer->replicaLayer())
2663 synchronizedPaintRecursively(replicaLayer); 2651 synchronizedPaintRecursively(replicaLayer);
2664 } 2652 }
2665 2653
(...skipping 1620 matching lines...) Expand 10 before | Expand all | Expand 10 after
4286 } 4274 }
4287 4275
4288 bool FrameView::canThrottleRendering() const 4276 bool FrameView::canThrottleRendering() const
4289 { 4277 {
4290 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled()) 4278 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
4291 return false; 4279 return false;
4292 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling); 4280 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling);
4293 } 4281 }
4294 4282
4295 } // namespace blink 4283 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698