Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issue 2163053002: [webcrypto] Check for empty key usages *after* key creation rather than before, to match the spec's… (Closed)

Created:
4 years, 5 months ago by eroman
Modified:
4 years, 4 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[webcrypto] Check for empty key usages *after* key creation rather than before, to match the spec's order of failures. This affects: * importKey() * generateKey() * unwrapKey() This also removes a "fail-fast optimization" on key usage when importing JWK asymmetric keys, as that was not supported by the spec. BUG=611801 Committed: https://crrev.com/0bb976e4a86cd456a35d861e7fb7f9e9a729a1a5 Cr-Commit-Position: refs/heads/master@{#409471}

Patch Set 1 #

Patch Set 2 : rename test #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+358 lines, -424 lines) Patch
M components/webcrypto/algorithm_dispatch.cc View 5 chunks +33 lines, -24 lines 0 comments Download
M components/webcrypto/algorithm_implementation.h View 2 chunks +48 lines, -95 lines 0 comments Download
M components/webcrypto/algorithm_implementation.cc View 2 chunks +2 lines, -90 lines 0 comments Download
M components/webcrypto/algorithms/aes.h View 1 chunk +26 lines, -19 lines 0 comments Download
M components/webcrypto/algorithms/aes.cc View 4 chunks +33 lines, -7 lines 0 comments Download
M components/webcrypto/algorithms/asymmetric_key_util.h View 2 chunks +0 lines, -20 lines 0 comments Download
M components/webcrypto/algorithms/asymmetric_key_util.cc View 3 chunks +6 lines, -46 lines 0 comments Download
M components/webcrypto/algorithms/ec.h View 1 chunk +24 lines, -17 lines 0 comments Download
M components/webcrypto/algorithms/ec.cc View 4 chunks +43 lines, -11 lines 0 comments Download
M components/webcrypto/algorithms/hkdf.cc View 1 chunk +17 lines, -7 lines 0 comments Download
M components/webcrypto/algorithms/hmac.cc View 1 2 5 chunks +38 lines, -13 lines 0 comments Download
M components/webcrypto/algorithms/pbkdf2.cc View 1 2 2 chunks +12 lines, -5 lines 0 comments Download
M components/webcrypto/algorithms/rsa.h View 1 chunk +24 lines, -17 lines 0 comments Download
M components/webcrypto/algorithms/rsa.cc View 4 chunks +43 lines, -11 lines 0 comments Download
M components/webcrypto/algorithms/rsa_ssa_unittest.cc View 1 1 chunk +6 lines, -12 lines 0 comments Download
M components/webcrypto/algorithms/secret_key_util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/webcrypto/algorithms/secret_key_util.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M components/webcrypto/algorithms/util.h View 1 chunk +1 line, -10 lines 0 comments Download
M components/webcrypto/algorithms/util.cc View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/exportKey-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
eroman
4 years, 5 months ago (2016-07-19 22:09:13 UTC) #4
eroman
Ping. Still no rush on this, but just a reminder
4 years, 4 months ago (2016-08-01 20:38:43 UTC) #9
Ryan Sleevi
lgtm
4 years, 4 months ago (2016-08-03 01:40:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2163053002/40001
4 years, 4 months ago (2016-08-03 05:58:09 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-03 06:36:58 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 06:38:44 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0bb976e4a86cd456a35d861e7fb7f9e9a729a1a5
Cr-Commit-Position: refs/heads/master@{#409471}

Powered by Google App Engine
This is Rietveld 408576698