Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: base/version.h

Issue 2163033002: base::Version constructor from std::vector<uint32_t> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/version.cc » ('j') | base/version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/version.h
diff --git a/base/version.h b/base/version.h
index 25b570a4e3f157636cd0e22f095ff368a56a30d9..3e2018e9b04a7ba8c107cca8941d4b0a65b03732 100644
--- a/base/version.h
+++ b/base/version.h
@@ -32,6 +32,8 @@ class BASE_EXPORT Version {
// the outcome.
explicit Version(const std::string& version_str);
+ explicit Version(std::vector<uint32_t>&& components);
danakj 2016/07/19 19:59:27 this should come with an operator=. This also del
Alex Z. 2016/07/19 20:46:13 Done. A copy constructor is explicitly defined (an
danakj 2016/07/19 20:50:07 Oh, there it is. Can you reorder this so that all
+
// Returns true if the object contains a valid version number.
bool IsValid() const;
« no previous file with comments | « no previous file | base/version.cc » ('j') | base/version.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698