base::Version constructor from std::vector<uint32_t>

base/version.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_VERSION_H_
 #define BASE_VERSION_H_
 
 #include <stdint.h>
 
 #include <iosfwd>
@@ skipping 14 matching lines @@
 
   Version(const Version& other);
 
   ~Version();
 
   // Initializes from a decimal dotted version number, like "0.1.1".
   // Each component is limited to a uint16_t. Call IsValid() to learn
   // the outcome.
   explicit Version(const std::string& version_str);
 
+  explicit Version(std::vector<uint32_t>&& components);

[danakj, 2016/07/19 19:59:27]

this should come with an operator=.

This also deletes the implicit copy constructor. Is that intentional? 

[Alex Z., 2016/07/19 20:46:13]

Done.
A copy constructor is explicitly defined (and set to default) at line 26 and
base/version.cc:83.

[danakj, 2016/07/19 20:50:07]

Oh, there it is. Can you reorder this so that all the constructors are coming
before the destructor?

+
   // Returns true if the object contains a valid version number.
   bool IsValid() const;
 
   // Returns true if the version wildcard string is valid. The version wildcard
   // string may end with ".*" (e.g. 1.2.*, 1.*). Any other arrangement with "*"
   // is invalid (e.g. 1.*.3 or 1.2.3*). This functions defaults to standard
   // Version behavior (IsValid) if no wildcard is present.
   static bool IsValidWildcardString(const std::string& wildcard_string);
 
   // Returns -1, 0, 1 for <, ==, >.
@@ skipping 22 matching lines @@
 BASE_EXPORT bool operator>=(const Version& v1, const Version& v2);
 BASE_EXPORT std::ostream& operator<<(std::ostream& stream, const Version& v);
 
 }  // namespace base
 
 // TODO(xhwang) remove this when all users are updated to explicitly use the
 // namespace
 using base::Version;
 
 #endif  // BASE_VERSION_H_