base/synchronization/cancellation_flag.cc - Issue 2163023002: Unify usage of logging/assert macros in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/cancellation_flag.cc

Issue 2163023002: Unify usage of logging/assert macros in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: oops commit on wrong branch Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/synchronization/cancellation_flag.cc

diff --git a/base/synchronization/cancellation_flag.cc b/base/synchronization/cancellation_flag.cc

index ca5c0a82837070742e63914f79e57d924721efd4..369080e59d0eb09b24fbc8650b39b8f622704aac 100644

--- a/base/synchronization/cancellation_flag.cc

+++ b/base/synchronization/cancellation_flag.cc

@@ -4,12 +4,10 @@

#include "base/synchronization/cancellation_flag.h"

-#include "base/logging.h"

namespace base {

void CancellationFlag::Set() {

-#if !defined(NDEBUG)

+#if DCHECK_IS_ON()

DCHECK_EQ(set_on_, PlatformThread::CurrentId());

#endif

base::subtle::Release_Store(&flag_, 1);