base/threading/thread_restrictions.h - Issue 2163023002: Unify usage of logging/assert macros in base/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/thread_restrictions.h

Issue 2163023002: Unify usage of logging/assert macros in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/threading/thread_restrictions.h

diff --git a/base/threading/thread_restrictions.h b/base/threading/thread_restrictions.h

index 0f3ad30e4ee3928bfe6813354bfda776e14c916e..1ffcf0ef87edd2b8ba63194c6c6af238498be400 100644

--- a/base/threading/thread_restrictions.h

+++ b/base/threading/thread_restrictions.h

@@ -6,10 +6,11 @@

#define BASE_THREADING_THREAD_RESTRICTIONS_H_

#include "base/base_export.h"

+#include "base/logging.h"

#include "base/macros.h"

// See comment at top of thread_checker.h

-#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))

+#if DCHECK_IS_ON()

#define ENABLE_THREAD_RESTRICTIONS 1

danakj 2016/07/19 20:17:02 dittos?

gab 2016/07/20 02:43:58 This one was used across the codebase, switched to

#else

#define ENABLE_THREAD_RESTRICTIONS 0