Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: base/bind_unittest.cc

Issue 2163023002: Unify usage of logging/assert macros in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/i18n/icu_util.cc » ('j') | base/i18n/icu_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/bind_unittest.cc
diff --git a/base/bind_unittest.cc b/base/bind_unittest.cc
index 5a7ce38627a44d3d5e225e95fc7b9191ce8e259b..b098bf70d463ef42bb0b4c4530d1ee915b5eece8 100644
--- a/base/bind_unittest.cc
+++ b/base/bind_unittest.cc
@@ -9,6 +9,7 @@
#include <vector>
#include "base/callback.h"
+#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/memory/ref_counted.h"
@@ -1065,7 +1066,7 @@ TEST_F(BindTest, WindowsCallingConventions) {
}
#endif
-#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)) && GTEST_HAS_DEATH_TEST
+#if DCHECK_IS_ON() && GTEST_HAS_DEATH_TEST
// Test null callbacks cause a DCHECK.
TEST(BindDeathTest, NullCallback) {
@@ -1074,8 +1075,7 @@ TEST(BindDeathTest, NullCallback) {
EXPECT_DEATH(base::Bind(null_cb, 42), "");
}
-#endif // (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)) &&
- // GTEST_HAS_DEATH_TEST
+#endif // DCHECK_IS_ON() && GTEST_HAS_DEATH_TEST
} // namespace
} // namespace base
« no previous file with comments | « no previous file | base/i18n/icu_util.cc » ('j') | base/i18n/icu_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698