Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: telemetry/telemetry/internal/actions/pinch.js

Issue 2162963002: [polymer] Merge of master into polymer10-migration (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Merge polymer10-migration int polymer10-merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/actions/mouse_click.py ('k') | telemetry/telemetry/internal/actions/pinch.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/actions/pinch.js
diff --git a/telemetry/telemetry/internal/actions/pinch.js b/telemetry/telemetry/internal/actions/pinch.js
index bdada3aa154695e306a269ebb5f086323d892584..4abb66e6431620ec2f4db92cefed3eb091bc2dee 100644
--- a/telemetry/telemetry/internal/actions/pinch.js
+++ b/telemetry/telemetry/internal/actions/pinch.js
@@ -29,7 +29,9 @@
function supportedByBrowser() {
return !!(window.chrome &&
chrome.gpuBenchmarking &&
- chrome.gpuBenchmarking.pinchBy);
+ chrome.gpuBenchmarking.pinchBy &&
+ chrome.gpuBenchmarking.visualViewportHeight &&
+ chrome.gpuBenchmarking.visualViewportWidth);
}
// This class zooms into or out of a page, given a number of pixels for
@@ -37,8 +39,8 @@
function PinchAction(opt_callback) {
var self = this;
- this.beginMeasuringHook = function() {}
- this.endMeasuringHook = function() {}
+ this.beginMeasuringHook = function() {};
+ this.endMeasuringHook = function() {};
this.callback_ = opt_callback;
};
« no previous file with comments | « telemetry/telemetry/internal/actions/mouse_click.py ('k') | telemetry/telemetry/internal/actions/pinch.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698