Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: telemetry/telemetry/internal/actions/mouse_click.py

Issue 2162963002: [polymer] Merge of master into polymer10-migration (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Merge polymer10-migration int polymer10-merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « telemetry/telemetry/internal/actions/media_action.py ('k') | telemetry/telemetry/internal/actions/pinch.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/actions/mouse_click.py
diff --git a/telemetry/telemetry/internal/actions/mouse_click.py b/telemetry/telemetry/internal/actions/mouse_click.py
index 069afe887fe0835814105d43b08e5f50fd7a2790..67527ae8553e51c9bbf2fa05ff70d42d2845159d 100644
--- a/telemetry/telemetry/internal/actions/mouse_click.py
+++ b/telemetry/telemetry/internal/actions/mouse_click.py
@@ -1,19 +1,11 @@
# Copyright 2015 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-import os
from telemetry.internal.actions import page_action
-
-
-def read_js():
- with open(os.path.join(os.path.dirname(__file__), 'mouse_click.js')) as f:
- return f.read()
-
+from telemetry.internal.actions import utils
class MouseClickAction(page_action.PageAction):
- _MOUSE_CLICK_JAVASCRIPT = read_js()
-
def __init__(self, selector=None):
super(MouseClickAction, self).__init__()
self._selector = selector
@@ -21,7 +13,7 @@ class MouseClickAction(page_action.PageAction):
def WillRunAction(self, tab):
"""Load the mouse click JS code prior to running the action."""
super(MouseClickAction, self).WillRunAction(tab)
- tab.ExecuteJavaScript(MouseClickAction._MOUSE_CLICK_JAVASCRIPT)
+ utils.InjectJavaScript(tab, 'mouse_click.js')
done_callback = 'function() { window.__mouseClickActionDone = true; }'
tab.ExecuteJavaScript("""
window.__mouseClickActionDone = false;
« no previous file with comments | « telemetry/telemetry/internal/actions/media_action.py ('k') | telemetry/telemetry/internal/actions/pinch.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698