[Password Generation] Fixes bug in sending CSS classes to the server

[Password Generation] Fixes bug in sending CSS classes to the server

This CL fixes two issues of another CL (https://codereview.chromium.org/2073093002):
1) FormFieldData.css_classes was missed in IPC_STRUCT_TRAITS_BEGIN(autofill::FormFieldData) in autofill_messages.h
2) There is no need in AutofillField.css_classes_. It is a duplicate of FormFieldData.css_classes

BUG=582434
Committed: https://crrev.com/d6897f621a614c6768f08fbb779b915f9039c3ad
Cr-Commit-Position: refs/heads/master@{#406514}

[kolos1, 2016-07-19 14:30:43]

Description was changed from

==========
[Password Generation] Fixes bug in sending CSS classes to the server

1) FormFieldData.css_classes was missed in
IPC_STRUCT_TRAITS_BEGIN(autofill::FormFieldData) in autofill_messages.h
2) There is no need in AutofillField.css_classes_. It is a duplicate of
FormFieldData.css_classes

BUG=582434
==========

to

==========
[Password Generation] Fixes bug in sending CSS classes to the server

This CL fixes two issues of another CL
(https://codereview.chromium.org/2073093002):
1) FormFieldData.css_classes was missed in
IPC_STRUCT_TRAITS_BEGIN(autofill::FormFieldData) in autofill_messages.h
2) There is no need in AutofillField.css_classes_. It is a duplicate of
FormFieldData.css_classes

BUG=582434
==========

[kolos1, 2016-07-19 14:55:21]

kolos@chromium.org changed reviewers:
+ vabr@chromium.org

[kolos1, 2016-07-19 14:55:21]

Hi Vaclav,

Please review tiny change in components/autofill/core/browser/autofill_field.h

I tried to add tests for these issues. It is possible to add a test
(password_autofill_agent_browsertests.cc) that checks if'css_classes'
successfully goes from rendered from browser via IPC. But it will checks just
new line in autofill_messages.h ('IPC_STRUCT_TRAITS_MEMBER(css_classes)'). AFAK,
it is not possible to check the chain from form_autofill_utils (where
css_classes is initialized) to form_structure (where css_classes is uploaded to
the server). So, I left these issues w/o tests. 

Best regards,
Maxim

[vabr (Chromium), 2016-07-19 16:27:10]

lgtm

[kolos1, 2016-07-19 16:29:29]

kolos@chromium.org changed reviewers:
+ mkwst@chromium.org

[kolos1, 2016-07-19 16:29:30]

mkwst@: Please review changes in autofill_messages.h

[kolos1, 2016-07-19 16:30:39]

The CQ bit was checked by kolos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 16:31:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 17:08:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 17:08:40]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-07-20 07:29:05]

LGTM.

[kolos1, 2016-07-20 07:47:01]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2016-07-20 07:47:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 08:15:22]

Description was changed from

==========
[Password Generation] Fixes bug in sending CSS classes to the server

This CL fixes two issues of another CL
(https://codereview.chromium.org/2073093002):
1) FormFieldData.css_classes was missed in
IPC_STRUCT_TRAITS_BEGIN(autofill::FormFieldData) in autofill_messages.h
2) There is no need in AutofillField.css_classes_. It is a duplicate of
FormFieldData.css_classes

BUG=582434
==========

to

==========
[Password Generation] Fixes bug in sending CSS classes to the server

This CL fixes two issues of another CL
(https://codereview.chromium.org/2073093002):
1) FormFieldData.css_classes was missed in
IPC_STRUCT_TRAITS_BEGIN(autofill::FormFieldData) in autofill_messages.h
2) There is no need in AutofillField.css_classes_. It is a duplicate of
FormFieldData.css_classes

BUG=582434
==========

[commit-bot: I haz the power, 2016-07-20 08:15:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-20 08:15:25]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 08:16:42]

Description was changed from

==========
[Password Generation] Fixes bug in sending CSS classes to the server

This CL fixes two issues of another CL
(https://codereview.chromium.org/2073093002):
1) FormFieldData.css_classes was missed in
IPC_STRUCT_TRAITS_BEGIN(autofill::FormFieldData) in autofill_messages.h
2) There is no need in AutofillField.css_classes_. It is a duplicate of
FormFieldData.css_classes

BUG=582434
==========

to

==========
[Password Generation] Fixes bug in sending CSS classes to the server

This CL fixes two issues of another CL
(https://codereview.chromium.org/2073093002):
1) FormFieldData.css_classes was missed in
IPC_STRUCT_TRAITS_BEGIN(autofill::FormFieldData) in autofill_messages.h
2) There is no need in AutofillField.css_classes_. It is a duplicate of
FormFieldData.css_classes

BUG=582434

Committed: https://crrev.com/d6897f621a614c6768f08fbb779b915f9039c3ad
Cr-Commit-Position: refs/heads/master@{#406514}
==========

[commit-bot: I haz the power, 2016-07-20 08:16:44]

Patchset 1 (id:??) landed as
https://crrev.com/d6897f621a614c6768f08fbb779b915f9039c3ad
Cr-Commit-Position: refs/heads/master@{#406514}

[vabr (Chromium), 2016-07-20 08:39:28]

Following up on our off-line discussion:
components/autofill/content/public/interfaces/autofill_types.mojom contains also
a description of FormFieldData, and seems to be missing css_classes. Could you
please add it there as well?

Thanks!
Vaclav