tools/testing/dart/test_options.dart - Issue 2162793004: Resolve disagreement between build.py and test.py over which architectures are included in 'all'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_options.dart

Issue 2162793004: Resolve disagreement between build.py and test.py over which architectures are included in 'all'. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_options.dart

diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart

index da2c5d047424cead0c942522fba094cff324362f..ee9c10799b10a28616468ecf08de58190dca39ed 100644

--- a/tools/testing/dart/test_options.dart

+++ b/tools/testing/dart/test_options.dart

@@ -703,7 +703,7 @@ Note: currently only implemented for dart2js.''',

List<Map> _expandConfigurations(Map configuration) {

// Expand the pseudo-values such as 'all'.

if (configuration['arch'] == 'all') {

- configuration['arch'] = 'ia32,x64,simarm,simarm64,simmips,simdbc';

+ configuration['arch'] = 'ia32,x64,simarm,simarm64,simmips,simdbc64';

}

if (configuration['mode'] == 'all') {

configuration['mode'] = 'debug,release,product';

« no previous file with comments | « no previous file | no next file » | no next file with comments »