Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: tools/testing/dart/test_options.dart

Issue 2162793004: Resolve disagreement between build.py and test.py over which architectures are included in 'all'. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test_options_parser; 5 library test_options_parser;
6 6
7 import "dart:io"; 7 import "dart:io";
8 import "drt_updater.dart"; 8 import "drt_updater.dart";
9 import "test_suite.dart"; 9 import "test_suite.dart";
10 import "path.dart"; 10 import "path.dart";
(...skipping 685 matching lines...) Expand 10 before | Expand all | Expand 10 after
696 return isValid; 696 return isValid;
697 } 697 }
698 698
699 /** 699 /**
700 * Recursively expand a configuration with multiple values per key 700 * Recursively expand a configuration with multiple values per key
701 * into a list of configurations with exactly one value per key. 701 * into a list of configurations with exactly one value per key.
702 */ 702 */
703 List<Map> _expandConfigurations(Map configuration) { 703 List<Map> _expandConfigurations(Map configuration) {
704 // Expand the pseudo-values such as 'all'. 704 // Expand the pseudo-values such as 'all'.
705 if (configuration['arch'] == 'all') { 705 if (configuration['arch'] == 'all') {
706 configuration['arch'] = 'ia32,x64,simarm,simarm64,simmips,simdbc'; 706 configuration['arch'] = 'ia32,x64,simarm,simarm64,simmips,simdbc64';
707 } 707 }
708 if (configuration['mode'] == 'all') { 708 if (configuration['mode'] == 'all') {
709 configuration['mode'] = 'debug,release,product'; 709 configuration['mode'] = 'debug,release,product';
710 } 710 }
711 711
712 if (configuration['report_in_json']) { 712 if (configuration['report_in_json']) {
713 configuration['list'] = true; 713 configuration['list'] = true;
714 configuration['report'] = true; 714 configuration['report'] = true;
715 } 715 }
716 716
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
904 if (option.keys.contains(name)) { 904 if (option.keys.contains(name)) {
905 return option; 905 return option;
906 } 906 }
907 } 907 }
908 print('Unknown test option $name'); 908 print('Unknown test option $name');
909 exit(1); 909 exit(1);
910 } 910 }
911 911
912 List<_TestOptionSpecification> _options; 912 List<_TestOptionSpecification> _options;
913 } 913 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698