Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2162793004: Resolve disagreement between build.py and test.py over which architectures are included in 'all'. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Resolve disagreement between build.py and test.py over which architectures are included in 'all'. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/7fa49e9910d3c424a8da385fba5dd2961962fe69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testing/dart/test_options.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 5 months ago (2016-07-19 22:16:37 UTC) #2
zra
lgtm
4 years, 5 months ago (2016-07-19 22:23:36 UTC) #3
rmacnak
4 years, 5 months ago (2016-07-19 22:32:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7fa49e9910d3c424a8da385fba5dd2961962fe69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698