Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2162693002: Move bitmap uploader to ui service client lib (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, droger+watchlist_chromium.org, tfarina, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move bitmap uploader to ui service client lib TBR=sky@chromium.org BUG=none Committed: https://crrev.com/d78421b1adf3938d85611145292c0d28e78c9955 Cr-Commit-Position: refs/heads/master@{#406626}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -427 lines) Patch
D components/bitmap_uploader/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D components/bitmap_uploader/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
D components/bitmap_uploader/OWNERS View 1 chunk +0 lines, -11 lines 0 comments Download
D components/bitmap_uploader/bitmap_uploader.h View 1 chunk +0 lines, -94 lines 0 comments Download
D components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +0 lines, -210 lines 0 comments Download
D components/bitmap_uploader/bitmap_uploader_export.h View 1 chunk +0 lines, -32 lines 0 comments Download
M content/browser/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/compositor/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/software_output_device_mus.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M services/ui/demo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/demo/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/demo/mus_demo.h View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M services/ui/demo/mus_demo.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M services/ui/public/cpp/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
A + services/ui/public/cpp/bitmap_uploader.h View 4 chunks +11 lines, -16 lines 0 comments Download
A + services/ui/public/cpp/lib/bitmap_uploader.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162693002/40001
4 years, 5 months ago (2016-07-20 17:10:30 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 18:47:46 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 18:47:52 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 18:49:29 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d78421b1adf3938d85611145292c0d28e78c9955
Cr-Commit-Position: refs/heads/master@{#406626}

Powered by Google App Engine
This is Rietveld 408576698