Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: cc/output/overlay_unittest.cc

Issue 2162663003: Don't reject overlay candidates for premultiplied alpha. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/output/overlay_candidate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "cc/base/region.h" 10 #include "cc/base/region.h"
(...skipping 504 matching lines...) Expand 10 before | Expand all | Expand 10 after
515 pass->shared_quad_state_list.back(), pass.get()); 515 pass->shared_quad_state_list.back(), pass.get());
516 516
517 // Check for potential candidates. 517 // Check for potential candidates.
518 OverlayCandidateList candidate_list; 518 OverlayCandidateList candidate_list;
519 overlay_processor_->ProcessForOverlays(resource_provider_.get(), pass.get(), 519 overlay_processor_->ProcessForOverlays(resource_provider_.get(), pass.get(),
520 &candidate_list, nullptr, 520 &candidate_list, nullptr,
521 &damage_rect_); 521 &damage_rect_);
522 EXPECT_EQ(1U, candidate_list.size()); 522 EXPECT_EQ(1U, candidate_list.size());
523 } 523 }
524 524
525 TEST_F(SingleOverlayOnTopTest, RejectPremultipliedAlpha) {
526 std::unique_ptr<RenderPass> pass = CreateRenderPass();
527 TextureDrawQuad* quad =
528 CreateFullscreenCandidateQuad(resource_provider_.get(),
529 pass->shared_quad_state_list.back(),
530 pass.get());
531 quad->premultiplied_alpha = true;
532
533 OverlayCandidateList candidate_list;
534 overlay_processor_->ProcessForOverlays(resource_provider_.get(), pass.get(),
535 &candidate_list, nullptr,
536 &damage_rect_);
537 EXPECT_EQ(0U, candidate_list.size());
538 }
539
540 TEST_F(SingleOverlayOnTopTest, RejectBlending) { 525 TEST_F(SingleOverlayOnTopTest, RejectBlending) {
541 std::unique_ptr<RenderPass> pass = CreateRenderPass(); 526 std::unique_ptr<RenderPass> pass = CreateRenderPass();
542 TextureDrawQuad* quad = 527 TextureDrawQuad* quad =
543 CreateFullscreenCandidateQuad(resource_provider_.get(), 528 CreateFullscreenCandidateQuad(resource_provider_.get(),
544 pass->shared_quad_state_list.back(), 529 pass->shared_quad_state_list.back(),
545 pass.get()); 530 pass.get());
546 quad->needs_blending = true; 531 quad->needs_blending = true;
547 532
548 OverlayCandidateList candidate_list; 533 OverlayCandidateList candidate_list;
549 overlay_processor_->ProcessForOverlays(resource_provider_.get(), pass.get(), 534 overlay_processor_->ProcessForOverlays(resource_provider_.get(), pass.get(),
(...skipping 1098 matching lines...) Expand 10 before | Expand all | Expand 10 after
1648 1633
1649 ReturnResourceInUseQuery(resource2); 1634 ReturnResourceInUseQuery(resource2);
1650 ReturnResourceInUseQuery(resource3); 1635 ReturnResourceInUseQuery(resource3);
1651 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource1)); 1636 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource1));
1652 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource2)); 1637 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource2));
1653 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource3)); 1638 EXPECT_FALSE(resource_provider_->InUseByConsumer(resource3));
1654 } 1639 }
1655 1640
1656 } // namespace 1641 } // namespace
1657 } // namespace cc 1642 } // namespace cc
OLDNEW
« no previous file with comments | « cc/output/overlay_candidate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698