Extract TitleUtil from NewTabPageView

Extract TitleUtil from NewTabPageView

BUG=616090
Committed: https://crrev.com/14c8935eb99561c26e1f804681243dda31b120cf
Cr-Commit-Position: refs/heads/master@{#406834}

[Michael van Ouwerkerk, 2016-07-19 10:02:43]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 10:03:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael van Ouwerkerk, 2016-07-19 10:03:27]

mvanouwerkerk@chromium.org changed reviewers:
+ bauerb@chromium.org

[Michael van Ouwerkerk, 2016-07-19 10:03:27]

Bernhard, could you take a look please?

[Bernhard Bauer, 2016-07-19 11:36:29]

LGTM, but we could clean up the method a bit while we're at it.

https://codereview.chromium.org/2162653003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java
(right):

https://codereview.chromium.org/2162653003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java:21: if
(TextUtils.isEmpty(title) && url != null) {
I would return early in this case.

https://codereview.chromium.org/2162653003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java:25: if
(host == null) host = "";
Move this to where |host| is initialized?

https://codereview.chromium.org/2162653003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java:26: if
(TextUtils.isEmpty(path) || path.equals("/")) path = "";
TextUtils.isEmpty() checks for null or the empty string, right? In the empty
string case, this would be a no-op anyway, so we might as well just check for
null.

[commit-bot: I haz the power, 2016-07-19 12:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 12:33:18]

Dry run: This issue passed the CQ dry run.

[Michael van Ouwerkerk, 2016-07-21 12:46:15]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 12:46:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael van Ouwerkerk, 2016-07-21 12:47:03]

All done. I've added a unit test, owners, and watch list. Please take another
look.

https://codereview.chromium.org/2162653003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java
(right):

https://codereview.chromium.org/2162653003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java:21: if
(TextUtils.isEmpty(title) && url != null) {
On 2016/07/19 11:36:29, Bernhard Bauer wrote:
> I would return early in this case.

Done.

https://codereview.chromium.org/2162653003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java:25: if
(host == null) host = "";
On 2016/07/19 11:36:29, Bernhard Bauer wrote:
> Move this to where |host| is initialized?

Done.

https://codereview.chromium.org/2162653003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java:26: if
(TextUtils.isEmpty(path) || path.equals("/")) path = "";
On 2016/07/19 11:36:29, Bernhard Bauer wrote:
> TextUtils.isEmpty() checks for null or the empty string, right? In the empty
> string case, this would be a no-op anyway, so we might as well just check for
> null.

Done.

[Bernhard Bauer, 2016-07-21 13:11:50]

Thanks! Still LGTM

[Michael van Ouwerkerk, 2016-07-21 13:20:39]

The CQ bit was unchecked by mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2016-07-21 13:20:45]

The CQ bit was checked by mvanouwerkerk@chromium.org

[commit-bot: I haz the power, 2016-07-21 13:20:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 13:45:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-21 13:47:04]

Description was changed from

==========
Extract TitleUtil from NewTabPageView

BUG=616090
==========

to

==========
Extract TitleUtil from NewTabPageView

BUG=616090

Committed: https://crrev.com/14c8935eb99561c26e1f804681243dda31b120cf
Cr-Commit-Position: refs/heads/master@{#406834}
==========

[commit-bot: I haz the power, 2016-07-21 13:47:05]

Patchset 2 (id:??) landed as
https://crrev.com/14c8935eb99561c26e1f804681243dda31b120cf
Cr-Commit-Position: refs/heads/master@{#406834}