chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java - Issue 2162653003: Extract TitleUtil from NewTabPageView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

Issue 2162653003: Extract TitleUtil from NewTabPageView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Address bauerb's comments. Add unit test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/TitleUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

index 6c7a86617a73aa3fcb773b69f52764460d3fca58..b4d6e437a764a48fce55828997423d946fa64c3c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

@@ -494,7 +494,7 @@ public void configureChildView(int childPosition, ViewHolder viewHolder) {

viewHolder.textView, R.drawable.history_favicon, 0, 0, 0);

} else {

RecentlyClosedTab tab = getChild(childPosition);

- String title = NewTabPageView.getTitleForDisplay(tab.title, tab.url);

+ String title = TitleUtil.getTitleForDisplay(tab.title, tab.url);

viewHolder.textView.setText(title);

loadLocalFavicon(viewHolder, tab.url);

}