Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2162563002: [Skia] Convert Sk Images to a CIPD package (Closed)

Created:
4 years, 5 months ago by borenet2
Modified:
4 years, 5 months ago
Reviewers:
borenet, rmistry
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Depend on existence of assets/skimage/VERSION, not SK_IMAGE_VERSION #

Patch Set 3 : Depend on existence of assets/skimage/VERSION, not SK_IMAGE_VERSION #

Patch Set 4 : Fix whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+669 lines, -611 lines) Patch
M scripts/slave/recipe_modules/skia/api.py View 1 2 chunks +24 lines, -8 lines 0 comments Download
M scripts/slave/recipe_modules/skia/default_flavor.py View 1 chunk +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.py View 1 2 3 2 chunks +14 lines, -9 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Win-MSVC-GCE-CPU-AVX2-x86_64-Release.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 2 chunks +13 lines, -3 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_perf.expected/big_issue_number.json View 1 2 2 chunks +126 lines, -132 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.py View 1 2 14 chunks +41 lines, -31 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Android-GCC-GalaxyS3-GPU-Mali400-Arm7-Debug.json View 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug.json View 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 7 chunks +18 lines, -8 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Trybot.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/adb_in_path.json View 2 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/big_issue_number.json View 1 2 4 chunks +55 lines, -142 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/download_and_push_skimage.json View 2 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/download_and_push_skps.json View 2 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/failed_dm.json View 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/failed_get_hashes.json View 2 1 chunk +12 lines, -2 lines 0 comments Download
A + scripts/slave/recipes/skia/swarm_test.expected/legacy_skimage_version.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/missing_SKP_VERSION_device.json View 2 1 chunk +12 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json View 2 3 chunks +14 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.py View 1 8 chunks +38 lines, -24 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/No_downloaded_SKP_VERSION.json View 3 chunks +6 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json View 2 chunks +4 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-NVIDIA_Shield-GPU-TegraX1-Arm64-Debug-Vulkan.json View 3 chunks +6 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-Nexus7v2-GPU-Tegra3-Arm7-Release.json View 2 chunks +4 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release.json View 2 chunks +4 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 2 chunks +4 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 3 chunks +6 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 3 chunks +6 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 3 chunks +6 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleA-GPU-HD7770-x86_64-Release.json View 2 chunks +4 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release.json View 2 chunks +4 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release.json View 2 chunks +4 lines, -12 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json View 3 chunks +6 lines, -12 lines 0 comments Download
A + scripts/slave/recipes/skia/swarm_trigger.expected/legacy_skimage_version.json View 10 chunks +37 lines, -37 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
borenet
4 years, 5 months ago (2016-07-18 15:08:11 UTC) #2
rmistry
lgtm
4 years, 5 months ago (2016-07-18 15:12:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162563002/1
4 years, 5 months ago (2016-07-18 15:54:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/e4607f99670139e478d2f4a0255c16eae2ef293c
4 years, 5 months ago (2016-07-18 15:59:58 UTC) #7
borenet
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2154223003/ by borenet@google.com. ...
4 years, 5 months ago (2016-07-18 16:12:31 UTC) #8
borenet
On 2016/07/18 16:12:31, borenet wrote: > A revert of this CL (patchset #1 id:1) has ...
4 years, 5 months ago (2016-07-18 17:09:42 UTC) #10
rmistry
lgtm
4 years, 5 months ago (2016-07-18 17:14:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162563002/40001
4 years, 5 months ago (2016-07-18 17:17:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162563002/60001
4 years, 5 months ago (2016-07-18 17:22:50 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 17:27:35 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/31ac652981759addea5f...

Powered by Google App Engine
This is Rietveld 408576698