[Skia] Convert Sk Images to a CIPD package

scripts/slave/recipes/skia/swarm_trigger.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 # Recipe module for Skia Swarming trigger.
 
 
 import json
 
@@ skipping 543 matching lines @@
   api.gsutil.upload(
       name='upload line-by-line coverage data',
       source=dst_lbl_file,
       bucket='skia-infra',
       dest='/'.join(('coverage-json-v1', gs_json_path,
                      dst_lbl_file_basename)),
       env={'AWS_CREDENTIAL_FILE': None, 'BOTO_CONFIG': None},
   )
 
 
+def cipd_pkg(api, infrabots_dir, asset_name):
+  """Find and return the CIPD package info for the given asset."""
+  version_file = infrabots_dir.join('assets', asset_name, 'VERSION')
+  version = api.skia._readfile(version_file,
+                               name='read %s VERSION' % asset_name,
+                               test_data='0').rstrip()
+  version = 'version:%s' % version
+  return (asset_name, 'skia/bots/%s' % asset_name, version)
+
+
 def RunSteps(api):
   got_revision = checkout_steps(api)
   api.skia_swarming.setup(
       api.path['checkout'].join('infra', 'bots', 'tools', 'luci-go'),
       swarming_rev='')
 
   # Run gsutil.py to ensure that it's installed.
   api.gsutil(['help'])
 
   recipes_hash = isolate_recipes(api)
   extra_hashes = [recipes_hash]
 
   # Get ready to compile.
   compile_cipd_deps = []
   extra_compile_hashes = [recipes_hash]
 
   infrabots_dir = api.path['checkout'].join('infra', 'bots')
   if 'Infra' in api.properties['buildername']:
     return infra_swarm(api, got_revision, infrabots_dir, extra_hashes)
 
   builder_spec = api.skia.get_builder_spec(api.path['checkout'],
                                            api.properties['buildername'])
   builder_cfg = builder_spec['builder_cfg']
 
   # Android bots require an SDK.
   if 'Android' in api.properties['buildername']:
     android_sdk_version_file = infrabots_dir.join(
         'assets', 'android_sdk', 'VERSION')
     if api.path.exists(android_sdk_version_file):
-      android_sdk_version = api.skia._readfile(android_sdk_version_file,
-                                               name='read android_sdk VERSION',
-                                               test_data='0').rstrip()
-      android_sdk_version = 'version:%s' % android_sdk_version
-      pkg = ('android_sdk', 'skia/bots/android_sdk', android_sdk_version)
-      compile_cipd_deps.append(pkg)
+      compile_cipd_deps.append(cipd_pkg(api, infrabots_dir, 'android_sdk'))
     else:
       # TODO(borenet): Remove this legacy method after 7/1/2016.
       test_data = 'a27a70d73b85191b9e671ff2a44547c3f7cc15ee'
       hash_file = infrabots_dir.join('android_sdk_hash')
       # try/except as a temporary measure to prevent breakages for backfills
       # and branches.
       try:
         h = api.skia._readfile(hash_file,
                                name='Read android_sdk_hash',
                                test_data=test_data).rstrip()
@@ skipping 21 matching lines @@
   cipd_packages = []
 
   do_test_steps = builder_spec['do_test_steps']
   do_perf_steps = builder_spec['do_perf_steps']
 
   if not (do_test_steps or do_perf_steps):
     return
 
   api.skia.download_skps(api.path['slave_build'].join('tmp'),
                          api.path['slave_build'].join('skps'))
-  api.skia.download_images(api.path['slave_build'].join('tmp'),
-                           api.path['slave_build'].join('images'))
+  if api.path.exists(infrabots_dir.join('assets', 'skimage', 'VERSION')):
+    cipd_packages.append(cipd_pkg(api, infrabots_dir, 'skimage'))
+  else:
+    # TODO(borenet): Remove this once enough time has passed.
+    api.skia.download_images(api.path['slave_build'].join('tmp'),
+                             api.path['slave_build'].join('images'))
 
   test_task = None
   perf_task = None
   if do_test_steps:
     test_task = test_steps_trigger(api, builder_spec, got_revision,
                                    infrabots_dir, extra_hashes, cipd_packages)
   if do_perf_steps:
     perf_task = perf_steps_trigger(api, builder_spec, got_revision,
                                    infrabots_dir, extra_hashes, cipd_packages)
   is_trybot = builder_cfg['is_trybot']
   if test_task:
     test_steps_collect(api, test_task, builder_spec['upload_dm_results'],
                        got_revision, is_trybot, builder_cfg)
   if perf_task:
     perf_steps_collect(api, perf_task, builder_spec['upload_perf_results'],
                        got_revision, is_trybot)
 
 
 def test_for_bot(api, builder, mastername, slavename, testname=None,
-                 legacy_android_sdk=False, legacy_win_toolchain=False):
+                 legacy_android_sdk=False, legacy_win_toolchain=False,
+                 legacy_skimage_version=False):
   """Generate a test for the given bot."""
   testname = testname or builder
   test = (
     api.test(testname) +
     api.properties(buildername=builder,
                    mastername=mastername,
                    slavename=slavename,
                    buildnumber=5,
-                   revision='abc123') +
-    api.path.exists(
-        api.path['slave_build'].join('skia'),
-        api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt')
-    )
+                   revision='abc123')
   )
+  paths = [
+      api.path['slave_build'].join('skia'),
+      api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt'),
+  ]
   if 'Trybot' in builder:
     test += api.properties(issue=500,
                            patchset=1,
                            rietveld='https://codereview.chromium.org')
   if 'Android' in builder:
     if not legacy_android_sdk:
-      test += api.path.exists(api.path['slave_build'].join(
+      paths.append(api.path['slave_build'].join(
           'skia', 'infra', 'bots', 'assets', 'android_sdk', 'VERSION'))
   if 'Coverage' not in builder and 'Infra' not in builder:
     test += api.step_data(
         'upload new .isolated file for compile_skia',
         stdout=api.raw_io.output('def456 XYZ.isolated'))
   if 'Test' in builder:
     test += api.step_data(
         'upload new .isolated file for test_skia',
         stdout=api.raw_io.output('def456 XYZ.isolated'))
   if ('Test' in builder and 'Debug' in builder) or 'Perf' in builder or (
       'Valgrind' in builder and 'Test' in builder):
     test += api.step_data(
         'upload new .isolated file for perf_skia',
         stdout=api.raw_io.output('def456 XYZ.isolated'))
   if 'Housekeeper' in builder:
     test += api.step_data(
         'upload new .isolated file for housekeeper_skia',
         stdout=api.raw_io.output('def456 XYZ.isolated'))
   if 'Infra' in builder:
     test += api.step_data(
         'upload new .isolated file for infra_skia',
         stdout=api.raw_io.output('def456 XYZ.isolated'))
   if 'Win' in builder:
     if not legacy_win_toolchain:
-      test += api.path.exists(api.path['slave_build'].join(
+      paths.append(api.path['slave_build'].join(
           'skia', 'infra', 'bots', 'assets', 'win_toolchain', 'VERSION'))
+  if not legacy_skimage_version:
+    paths.append(api.path['slave_build'].join(
+        'skia', 'infra', 'bots', 'assets', 'skimage', 'VERSION'))
+
+  test += api.path.exists(*paths)
 
   return test
 
 
 def GenTests(api):
   for mastername, slaves in TEST_BUILDERS.iteritems():
     for slavename, builders_by_slave in slaves.iteritems():
       for builder in builders_by_slave:
         yield test_for_bot(api, builder, mastername, slavename)
 
   builder = 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug'
   master = 'client.skia'
   slave = 'skiabot-linux-test-000'
   test = test_for_bot(api, builder, master, slave, 'No_downloaded_SKP_VERSION')
   test += api.step_data('Get downloaded SKP_VERSION', retcode=1)
-  test += api.path.exists(
-      api.path['slave_build'].join('skia'),
-      api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt')
-  )
   yield test
 
   test = test_for_bot(api, builder, master, slave,
                       'Wrong_downloaded_SKP_VERSION')
   test += api.properties(test_downloaded_skp_version='999')
-  test += api.path.exists(
-      api.path['slave_build'].join('skia'),
-      api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt')
-  )
   yield test
 
   builder = 'Build-Ubuntu-GCC-Arm7-Release-Android_Vulkan'
   master = 'client.skia.compile'
   slave = 'skiabot-linux-compile-000'
   test = test_for_bot(api, builder, master, slave, 'legacy_android_sdk',
                       legacy_android_sdk=True)
   test += api.step_data('Read android_sdk_hash',
                         stdout=api.raw_io.output('<android_sdk_hash>'))
   yield test
 
   test = test_for_bot(api, builder, master, slave, 'Missing_android_sdk_hash',
                       legacy_android_sdk=True)
   test += api.step_data('Read android_sdk_hash', retcode=1)
   yield test
 
   builder = 'Build-Win-MSVC-x86_64-Release-Vulkan'
   master = 'client.skia.compile'
   test = test_for_bot(api, builder, master, slave, 'legacy_win_toolchain',
                       legacy_win_toolchain=True)
   yield test
+
+  builder = 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug'
+  master = 'client.skia'
+  test = test_for_bot(api, builder, master, slave, 'legacy_skimage_version',
+                      legacy_skimage_version=True)
+  test += api.step_data('Get downloaded SK_IMAGE_VERSION', retcode=1)
+  yield test