components/ntp_snippets/request_throttler_unittest.cc - Issue 2162533002: Adding a request counter to the snippets fetcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/request_throttler_unittest.cc

Issue 2162533002: Adding a request counter to the snippets fetcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@traffic-monitor

Patch Set: Fix the unittest Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/request_throttler.cc ('k') | ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/request_throttler_unittest.cc

diff --git a/components/ntp_snippets/request_throttler_unittest.cc b/components/ntp_snippets/request_throttler_unittest.cc

index e75295e996304e3f1414e0fd47bb43eae746264c..97c2b0200bff81e275704ca3ae531e556b71ac68 100644

--- a/components/ntp_snippets/request_throttler_unittest.cc

+++ b/components/ntp_snippets/request_throttler_unittest.cc

@@ -24,8 +24,9 @@ class RequestThrottlerTest : public testing::Test {

RequestThrottler::RegisterProfilePrefs(test_prefs_.registry());

// Use any arbitrary RequestType for this unittest.

throttler_.reset(new RequestThrottler(

- &test_prefs_, RequestThrottler::RequestType::CONTENT_SUGGESTION_FETCHER,

- kCounterQuota));

+ &test_prefs_,

+ RequestThrottler::RequestType::CONTENT_SUGGESTION_FETCHER));

+ throttler_->quota_ = kCounterQuota;

jkrcal 2016/07/26 10:05:07 Marc, moving the quota into the RequestTypeInfo co

Marc Treib 2016/07/26 10:10:17 I guess it's a matter of preference; I've seen bot

}

protected: