Adding a request counter to the snippets fetcher.

components/ntp_snippets/request_throttler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/request_throttler.h"
 
 #include <memory>
 
 #include "base/strings/stringprintf.h"
 #include "components/ntp_snippets/pref_names.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/testing_pref_service.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 const int kCounterQuota = 2;
 }  // namespace
 
 namespace ntp_snippets {
 
 class RequestThrottlerTest : public testing::Test {
  public:
   RequestThrottlerTest() {
     RequestThrottler::RegisterProfilePrefs(test_prefs_.registry());
     // Use any arbitrary RequestType for this unittest.
     throttler_.reset(new RequestThrottler(
-        &test_prefs_, RequestThrottler::RequestType::CONTENT_SUGGESTION_FETCHER,
-        kCounterQuota));
+        &test_prefs_,
+        RequestThrottler::RequestType::CONTENT_SUGGESTION_FETCHER));
+    throttler_->quota_ = kCounterQuota;

[jkrcal, 2016/07/26 10:05:07]

Marc, moving the quota into the RequestTypeInfo complicated the unit test. Is
accessing a private field from a friend class ok or is a new public method
SetQuotaForTest() preferred?

[Marc Treib, 2016/07/26 10:10:17]

I guess it's a matter of preference; I've seen both and am okay with either. I
slightly prefer the friend method, i.e. what you've done here.

   }
 
  protected:
   TestingPrefServiceSimple test_prefs_;
   std::unique_ptr<RequestThrottler> throttler_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(RequestThrottlerTest);
 };
 
@@ skipping 23 matching lines @@
   // yesterday.
   int now_day = (base::Time::Now() - base::Time::UnixEpoch()).InDays();
   test_prefs_.SetInteger(ntp_snippets::prefs::kSnippetFetcherQuotaDay,
                          now_day - 1);
 
   // The quota should get reset as the day has changed.
   EXPECT_TRUE(throttler_->DemandQuotaForRequest(false));
 }
 
 }  // namespace ntp_snippets