Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: Source/core/css/resolver/StyleBuilder.h

Issue 21625003: StyleBuilder should not know about StyleResolver. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/StyleBuilder.h
diff --git a/Source/core/css/resolver/StyleBuilder.h b/Source/core/css/resolver/StyleBuilder.h
index cd5e6bf28d166a947f64fa3c784d30179f8811eb..eb2e2c3a998a0809b4c22a259620ad92e0368af1 100644
--- a/Source/core/css/resolver/StyleBuilder.h
+++ b/Source/core/css/resolver/StyleBuilder.h
@@ -38,17 +38,20 @@ namespace WebCore {
class CSSValue;
class Document;
class RenderStyle;
-class StyleResolver;
class StyleResolverState;
class StyleBuilder {
public:
- static bool applyProperty(CSSPropertyID, StyleResolver*, StyleResolverState&, CSSValue*, bool isInitial, bool isInherit);
+ // FIXME: What's the endgame for this function?
eseidel 2013/08/01 21:09:53 What does endgame mean here?
dglazkov 2013/08/01 21:16:19 --> "Will this need further refactoring or is this
+ static void applyProperty(CSSPropertyID, StyleResolverState&, CSSValue*);
esprehn 2013/08/01 21:07:13 This is the public API to the style builder system
// This function contains the gigantic old switch-statement of properties inherited from
// StyleResolver. Each property should be migrated over to a new StyleBuilder templated
// function and removed from this code. Once they're all moved, this function can die.
- static void oldApplyProperty(CSSPropertyID, StyleResolver*, StyleResolverState&, CSSValue*, bool isInitial, bool isInherit);
+ static void oldApplyProperty(CSSPropertyID, StyleResolverState&, CSSValue*, bool isInitial, bool isInherit);
eseidel 2013/08/01 21:09:53 It's uncclear if it should depend on StyleResolver
+
+private:
+ static bool applyProperty(CSSPropertyID, StyleResolverState&, CSSValue*, bool isInitial, bool isInherit);
};
}
« no previous file with comments | « no previous file | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698