StyleBuilder should not know about StyleResolver.

Source/core/css/resolver/StyleBuilder.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 20 matching lines @@
 #ifndef StyleBuilder_h
 #define StyleBuilder_h
 
 #include "CSSPropertyNames.h"
 
 namespace WebCore {
 
 class CSSValue;
 class Document;
 class RenderStyle;
-class StyleResolver;
 class StyleResolverState;
 
 class StyleBuilder {
 public:
-    static bool applyProperty(CSSPropertyID, StyleResolver*, StyleResolverState&, CSSValue*, bool isInitial, bool isInherit);
+    // FIXME: What's the endgame for this function?

[eseidel, 2013/08/01 21:09:53]

What does endgame mean here?

[dglazkov, 2013/08/01 21:16:19]

--> "Will this need further refactoring or is this basically the API?"

I'll remove the comment altogether. It's not informative in any way.

+    static void applyProperty(CSSPropertyID, StyleResolverState&, CSSValue*);

[esprehn, 2013/08/01 21:07:13]

This is the public API to the style builder system, I don't think you need the
FIXME.

 
     // This function contains the gigantic old switch-statement of properties inherited from
     // StyleResolver. Each property should be migrated over to a new StyleBuilder templated
     // function and removed from this code. Once they're all moved, this function can die.
-    static void oldApplyProperty(CSSPropertyID, StyleResolver*, StyleResolverState&, CSSValue*, bool isInitial, bool isInherit);
+    static void oldApplyProperty(CSSPropertyID, StyleResolverState&, CSSValue*, bool isInitial, bool isInherit);

[eseidel, 2013/08/01 21:09:53]

It's uncclear if it should depend on StyleResolverState either. :)

+
+private:
+    static bool applyProperty(CSSPropertyID, StyleResolverState&, CSSValue*, bool isInitial, bool isInherit);
 };
 
 }
 
 #endif