Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2162473002: [system health] Add desktop browsing story for facebook and change url of twitter story. (Closed)

Created:
4 years, 5 months ago by ulan
Modified:
4 years, 5 months ago
Reviewers:
nednguyen, petrcermak
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[system health] Add desktop browsing story for facebook and change url of twitter story. *** NOTE TO SHERRIF *** Regressions are expected in - system_health.memory_mobile - system_health.memory_desktop - v8.browsing_mobile - v8.browsing_desktop for the following stories: - load:social:twitter - browse:social:twitter BUG=chromium:621035 Committed: https://crrev.com/0a7a65b967c020c7380cba3488b8316b56708ed7 Cr-Commit-Position: refs/heads/master@{#406267}

Patch Set 1 #

Total comments: 2

Patch Set 2 : record wpr, disable facebook #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M tools/perf/page_sets/data/system_health_desktop.json View 1 2 chunks +4 lines, -4 lines 0 comments Download
A tools/perf/page_sets/data/system_health_desktop_018.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/system_health_desktop_019.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/data/system_health_mobile.json View 1 2 chunks +7 lines, -7 lines 0 comments Download
A tools/perf/page_sets/data/system_health_mobile_022.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/system_health_mobile_023.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/system_health/browsing_stories.py View 1 2 chunks +12 lines, -4 lines 0 comments Download
M tools/perf/page_sets/system_health/loading_stories.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (12 generated)
ulan
ptal https://codereview.chromium.org/2162473002/diff/1/tools/perf/page_sets/system_health/browsing_stories.py File tools/perf/page_sets/system_health/browsing_stories.py (left): https://codereview.chromium.org/2162473002/diff/1/tools/perf/page_sets/system_health/browsing_stories.py#oldcode98 tools/perf/page_sets/system_health/browsing_stories.py:98: # directly in the main timeline. The comment ...
4 years, 5 months ago (2016-07-18 11:07:26 UTC) #2
petrcermak
LGTM. Please add a bug ID, or remove the "BUG=" line. Thanks, Petr
4 years, 5 months ago (2016-07-18 11:24:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162473002/20001
4 years, 5 months ago (2016-07-19 10:47:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/220466)
4 years, 5 months ago (2016-07-19 10:55:23 UTC) #12
ulan
Ned, could you please rubber-stamp as an owner?
4 years, 5 months ago (2016-07-19 13:30:47 UTC) #14
nednguyen
On 2016/07/19 13:30:47, ulan wrote: > Ned, could you please rubber-stamp as an owner? lgtm ...
4 years, 5 months ago (2016-07-19 13:46:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162473002/20001
4 years, 5 months ago (2016-07-19 13:54:54 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 13:59:43 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 13:59:47 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 14:01:04 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a7a65b967c020c7380cba3488b8316b56708ed7
Cr-Commit-Position: refs/heads/master@{#406267}

Powered by Google App Engine
This is Rietveld 408576698