tools/perf/page_sets/system_health/browsing_stories.py - Issue 2162473002: [system health] Add desktop browsing story for facebook and change url of twitter story.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/system_health/browsing_stories.py

Issue 2162473002: [system health] Add desktop browsing story for facebook and change url of twitter story. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: record wpr, disable facebook Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/page_sets/data/system_health_mobile_023.wpr.sha1 ('k') | tools/perf/page_sets/system_health/loading_stories.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/page_sets/system_health/browsing_stories.py

diff --git a/tools/perf/page_sets/system_health/browsing_stories.py b/tools/perf/page_sets/system_health/browsing_stories.py

index 072b2f42f831ef8f72ed15a57747046c5b55de3b..388e0ee5c3ea0c46d6988163c40715dbe8192216 100644

--- a/tools/perf/page_sets/system_health/browsing_stories.py

+++ b/tools/perf/page_sets/system_health/browsing_stories.py

@@ -94,11 +94,19 @@ class FacebookMobileStory(_NewsBrowsingStory):

NAME = 'browse:social:facebook'

URL = 'https://www.facebook.com/rihanna'

ITEM_SELECTOR = 'article ._5msj'

- # Facebook on desktop is not interesting because it embeds post comments

- # directly in the main timeline.

SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY

+class FacebookDesktopStory(_NewsBrowsingStory):

+ NAME = 'browse:social:facebook'

+ URL = 'https://www.facebook.com/rihanna'

+ ITEM_SELECTOR = '._4-eo'

+ IS_SINGLE_PAGE_APP = True

+ # Web-page-replay does not work for this website:

+ # https://github.com/chromium/web-page-replay/issues/79.

+ SUPPORTED_PLATFORMS = platforms.NO_PLATFORMS

class HackerNewsStory(_NewsBrowsingStory):

NAME = 'browse:news:hackernews'

URL = 'https://news.ycombinator.com'

@@ -152,14 +160,14 @@ class RedditMobileStory(_NewsBrowsingStory):

class TwitterMobileStory(_NewsBrowsingStory):

NAME = 'browse:social:twitter'

- URL = 'https://www.twitter.com/justinbieber?skip_interstitial=true'

+ URL = 'https://www.twitter.com/nasa'

ITEM_SELECTOR = '.Tweet-text'

SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY

class TwitterDesktopStory(_NewsBrowsingStory):

NAME = 'browse:social:twitter'

- URL = 'https://www.twitter.com/justinbieber?skip_interstitial=true'

+ URL = 'https://www.twitter.com/nasa'

IS_SINGLE_PAGE_APP = True

ITEM_SELECTOR = '.tweet-text'

SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY