Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2162443002: Add API to create a "remote" instance of a given FunctionTemplate (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add API to create a "remote" instance of a given FunctionTemplate BUG=chromium:618305 R=verwaest@chromium.org CC=dcheng@chromium.org,haraken@chromium.org Committed: https://crrev.com/562bb5823c4dd4eb8520b0f3fd3a969d3c4922cd Cr-Commit-Position: refs/heads/master@{#37867}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -0 lines) Patch
M include/v8.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M src/api-natives.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/api-natives.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M src/counters.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-access-checks.cc View 2 chunks +27 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (10 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-18 09:47:50 UTC) #1
Toon Verwaest
The overall approach looks good, but it's quite a hack that the bootstrapper creates this ...
4 years, 5 months ago (2016-07-18 12:29:43 UTC) #6
jochen (gone - plz use gerrit)
ptal moved stuff to api-natives
4 years, 5 months ago (2016-07-19 07:48:48 UTC) #7
Toon Verwaest
lgtm
4 years, 5 months ago (2016-07-19 11:24:09 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2161613002 Patch 20001). Please resolve the dependency and ...
4 years, 5 months ago (2016-07-19 11:26:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162443002/20001
4 years, 5 months ago (2016-07-19 11:29:20 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/21128) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-07-19 11:31:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162443002/20001
4 years, 5 months ago (2016-07-19 11:52:56 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 12:21:57 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 12:21:59 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 12:22:48 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/562bb5823c4dd4eb8520b0f3fd3a969d3c4922cd
Cr-Commit-Position: refs/heads/master@{#37867}

Powered by Google App Engine
This is Rietveld 408576698