Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 2161613002: Move SetObjectPrototype to JSObject (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move SetObjectPrototype to JSObject I plan to use this from ApiNatives, so move it to a common location. BUG= R=verwaest@chromium.org Committed: https://crrev.com/460e0b80a919c8f2dbc17c9742732ca0c18a54e4 Cr-Commit-Position: refs/heads/master@{#37865}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M src/bootstrapper.cc View 1 11 chunks +13 lines, -22 lines 0 comments Download
M src/objects.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-18 13:25:56 UTC) #1
Toon Verwaest
https://codereview.chromium.org/2161613002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/2161613002/diff/1/src/objects.cc#newcode3329 src/objects.cc:3329: void JSObject::SetObjectPrototype(Handle<JSObject> object, Can't you just use JSObject::SetPrototype? If ...
4 years, 5 months ago (2016-07-18 14:36:21 UTC) #6
jochen (gone - plz use gerrit)
renamed to ForceSetPrototype
4 years, 5 months ago (2016-07-18 15:33:52 UTC) #9
Toon Verwaest
lgtm
4 years, 5 months ago (2016-07-19 11:22:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2161613002/20001
4 years, 5 months ago (2016-07-19 11:25:59 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 11:28:50 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 11:28:53 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 11:30:45 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/460e0b80a919c8f2dbc17c9742732ca0c18a54e4
Cr-Commit-Position: refs/heads/master@{#37865}

Powered by Google App Engine
This is Rietveld 408576698