Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2162393002: [runtime] enable fast key accumulator by default (Closed)

Created:
4 years, 5 months ago by Camillo Bruni
Modified:
4 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] enable fast key accumulator by default BUG= Committed: https://crrev.com/55f903500adc6c00aa6f13467f0d9a5b4d7f2d0f Cr-Commit-Position: refs/heads/master@{#37932}

Patch Set 1 #

Patch Set 2 : remove empty branch #

Total comments: 1

Patch Set 3 : remove commented out code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M src/elements.cc View 1 3 chunks +19 lines, -6 lines 0 comments Download
M src/keys.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Camillo Bruni
PTAL
4 years, 5 months ago (2016-07-20 15:26:16 UTC) #4
Jakob Kummerow
lgtm https://codereview.chromium.org/2162393002/diff/20001/src/keys.cc File src/keys.cc (right): https://codereview.chromium.org/2162393002/diff/20001/src/keys.cc#newcode43 src/keys.cc:43: /* MAYBE_RETURN(accumulator.CollectKeys(object, object), */ What's this?
4 years, 5 months ago (2016-07-20 16:04:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162393002/40001
4 years, 5 months ago (2016-07-21 08:59:14 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 09:22:54 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 09:23:58 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/55f903500adc6c00aa6f13467f0d9a5b4d7f2d0f
Cr-Commit-Position: refs/heads/master@{#37932}

Powered by Google App Engine
This is Rietveld 408576698