Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: src/keys.cc

Issue 2162393002: [runtime] enable fast key accumulator by default (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: remove commented out code Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/elements.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/keys.cc
diff --git a/src/keys.cc b/src/keys.cc
index b73575fad0962c5b83d890fc52ceed3677ccc959..63b342e994795a0cb0198a86a73c970fc254a39c 100644
--- a/src/keys.cc
+++ b/src/keys.cc
@@ -31,15 +31,15 @@ static bool ContainsOnlyValidKeys(Handle<FixedArray> array) {
}
} // namespace
+
+// static
MaybeHandle<FixedArray> KeyAccumulator::GetKeys(
Handle<JSReceiver> object, KeyCollectionMode mode, PropertyFilter filter,
GetKeysConversion keys_conversion, bool filter_proxy_keys, bool is_for_in) {
Isolate* isolate = object->GetIsolate();
- KeyAccumulator accumulator(isolate, mode, filter);
+ FastKeyAccumulator accumulator(isolate, object, mode, filter);
accumulator.set_filter_proxy_keys(filter_proxy_keys);
accumulator.set_is_for_in(is_for_in);
- MAYBE_RETURN(accumulator.CollectKeys(object, object),
- MaybeHandle<FixedArray>());
return accumulator.GetKeys(keys_conversion);
}
« no previous file with comments | « src/elements.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698