Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216233008: Stop calling WebSetting::setFullScreenEnabled (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Stop calling WebSetting::setFullScreenEnabled The setting has been removed from Blink: https://codereview.chromium.org/217163004/ BUG=344002 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/renderer/web_preferences.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
philipj_slow
PTAL. Depends on https://codereview.chromium.org/217163004/ to land and roll first.
6 years, 8 months ago (2014-03-28 18:04:43 UTC) #1
eseidel
lgtm
6 years, 8 months ago (2014-03-28 18:31:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/216233008/1
6 years, 8 months ago (2014-03-28 18:32:47 UTC) #3
philipj_slow
The CQ bit was unchecked by philipj@opera.com
6 years, 8 months ago (2014-03-28 18:46:12 UTC) #4
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 8 months ago (2014-03-30 17:10:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/216233008/1
6 years, 8 months ago (2014-03-30 17:11:18 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 17:46:09 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58478
6 years, 8 months ago (2014-03-30 17:46:09 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-03-31 09:57:01 UTC) #9
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 8 months ago (2014-03-31 10:47:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/216233008/1
6 years, 8 months ago (2014-03-31 10:47:18 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 13:05:45 UTC) #12
Message was sent while issue was closed. 
Change committed as 260532

Powered by Google App Engine
This is Rietveld 408576698