Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2162243002: Recreate tab switcher stacks/lists when tabs are merged (Closed)

Created:
4 years, 5 months ago by Theresa
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Recreate tab switcher stacks/lists when tabs are merged If tabs from two instances of are merged while either the StackLayout or OverviewListLayout is active, recreate the view so that the merged tabs show up in the layout. BUG=602498 Committed: https://crrev.com/cd0688e84198b95815e29ba6127a1ea0c126a9b8 Cr-Commit-Position: refs/heads/master@{#406945}

Patch Set 1 #

Patch Set 2 : Recreate tab switcher stacks/lists when tabs are merged #

Total comments: 2

Patch Set 3 : Rebase #

Patch Set 4 : Reverse order of if/else #

Messages

Total messages: 14 (8 generated)
Theresa
ptal
4 years, 5 months ago (2016-07-20 00:09:21 UTC) #3
gone
LGTM, but it's kind of unfortunate that the interface can't just have a base implementation ...
4 years, 5 months ago (2016-07-21 20:06:24 UTC) #7
Theresa
https://chromiumcodereview.appspot.com/2162243002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java File chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java (right): https://chromiumcodereview.appspot.com/2162243002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java#newcode117 chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java:117: getActiveLayout().onTabRestored(time(), tabId); On 2016/07/21 20:06:24, dfalcantara wrote: > Maybe ...
4 years, 5 months ago (2016-07-21 20:23:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162243002/60001
4 years, 5 months ago (2016-07-21 20:32:59 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-21 21:20:45 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 21:23:44 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cd0688e84198b95815e29ba6127a1ea0c126a9b8
Cr-Commit-Position: refs/heads/master@{#406945}

Powered by Google App Engine
This is Rietveld 408576698