chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java - Issue 2162243002: Recreate tab switcher stacks/lists when tabs are merged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java

Issue 2162243002: Recreate tab switcher stacks/lists when tabs are merged (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reverse order of if/else Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java

index bc8939342203cc68672c884b5f35e26cc951d8cb..a961df781873e31c3b5b77d898688d3a28a161d6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java

@@ -344,6 +344,14 @@ public class StackLayout extends Layout implements Animatable<StackLayout.Proper

}

@Override

+ public void onTabRestored(long time, int tabId) {

+ super.onTabRestored(time, tabId);

+ // Call show() so that new stack tabs and potentially new stacks get created.

+ // TODO(twellington): add animation for showing the restored tab.

+ show(time, false);

+ }

+ @Override

public void onTabModelSwitched(boolean toIncognitoTabModel) {

flingStacks(toIncognitoTabModel);

mFlingFromModelChange = true;