Renaming Gnubby and RemoteSecurityKey files/classes/members

Renaming Gnubby and RemoteSecurityKey files/classes/members

This change is a simple refactoring to rename the 'Gnubby' and
'RemoteSecurityKey' file/class names/comments/etc to be consistent.
I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey
(which was causing too many 80 char limit issues).  No functional
changes are expected as a result of this change.

Note: Not every instance of Gnubby or RemoteSecurityKey has been
changed.  The registry key used for toggling this functionality still
uses 'gnubby'.  I don't want to change that here.  Also, the process
used on the host machine is still called remote_security_key so classes
associated with that process were not renamed (neither were the IPC
messages used by it).

BUG=593736
TBR=jochen@chromium.org

Committed: https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516
Cr-Commit-Position: refs/heads/master@{#406435}

[joedow, 2016-07-19 17:45:07]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 17:45:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-07-19 18:15:02]

Description was changed from

==========
Renaming Gnubby and RemoteSecurityKey files/classes/members

This change is a simple refactoring to rename the 'Gnubby' and
'RemoteSecurityKey' file/class names/comments/etc to be consistent.
I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey
(which was causing too many 80 char limit issues).  No functional
changes are expected as a result of this change.

BUG=593736
==========

to

==========
Renaming Gnubby and RemoteSecurityKey files/classes/members

This change is a simple refactoring to rename the 'Gnubby' and
'RemoteSecurityKey' file/class names/comments/etc to be consistent.
I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey
(which was causing too many 80 char limit issues).  No functional
changes are expected as a result of this change.

Note: Not every instance of Gnubby or RemoteSecurityKey has been
changed.  The registry key used for toggling this functionality still
uses 'gnubby'.  I don't want to change that here.  Also, the process
used on the host machine is still called remote_security_key so classes
associated with that process were not renamed (neither were the IPC
messages used by it).

BUG=593736
==========

[joedow, 2016-07-19 18:17:55]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 18:18:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-07-19 19:20:59]

joedow@chromium.org changed reviewers:
+ sergeyu@chromium.org

[joedow, 2016-07-19 19:21:00]

Sergey, can you take a look at the remoting renames? After you LGTM it, I will
add a reviewer for the presubmit change.

PTAL!

Thanks!
Joe

[commit-bot: I haz the power, 2016-07-19 19:24:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 19:24:27]

Dry run: This issue passed the CQ dry run.

[Sergey Ulanov, 2016-07-19 20:24:34]

lgtm.
I think it's acceptable to TBR the PRESUBMIT.py change.

[joedow, 2016-07-19 21:22:47]

Description was changed from

==========
Renaming Gnubby and RemoteSecurityKey files/classes/members

This change is a simple refactoring to rename the 'Gnubby' and
'RemoteSecurityKey' file/class names/comments/etc to be consistent.
I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey
(which was causing too many 80 char limit issues).  No functional
changes are expected as a result of this change.

Note: Not every instance of Gnubby or RemoteSecurityKey has been
changed.  The registry key used for toggling this functionality still
uses 'gnubby'.  I don't want to change that here.  Also, the process
used on the host machine is still called remote_security_key so classes
associated with that process were not renamed (neither were the IPC
messages used by it).

BUG=593736
==========

to

==========
Renaming Gnubby and RemoteSecurityKey files/classes/members

This change is a simple refactoring to rename the 'Gnubby' and
'RemoteSecurityKey' file/class names/comments/etc to be consistent.
I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey
(which was causing too many 80 char limit issues).  No functional
changes are expected as a result of this change.

Note: Not every instance of Gnubby or RemoteSecurityKey has been
changed.  The registry key used for toggling this functionality still
uses 'gnubby'.  I don't want to change that here.  Also, the process
used on the host machine is still called remote_security_key so classes
associated with that process were not renamed (neither were the IPC
messages used by it).

BUG=593736
TBR=jochen@chromium.org
==========

[joedow, 2016-07-19 21:23:23]

Thanks Sergey!  TBR'ing presubmit owner...

[joedow, 2016-07-19 21:23:31]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-07-19 21:23:32]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2162083003/#ps40001
(title: "Adding TBR")

[commit-bot: I haz the power, 2016-07-19 21:25:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 22:36:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 22:36:59]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[joedow, 2016-07-19 23:31:42]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-07-19 23:33:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 01:06:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-20 01:06:20]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 01:08:23]

Description was changed from

==========
Renaming Gnubby and RemoteSecurityKey files/classes/members

This change is a simple refactoring to rename the 'Gnubby' and
'RemoteSecurityKey' file/class names/comments/etc to be consistent.
I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey
(which was causing too many 80 char limit issues).  No functional
changes are expected as a result of this change.

Note: Not every instance of Gnubby or RemoteSecurityKey has been
changed.  The registry key used for toggling this functionality still
uses 'gnubby'.  I don't want to change that here.  Also, the process
used on the host machine is still called remote_security_key so classes
associated with that process were not renamed (neither were the IPC
messages used by it).

BUG=593736
TBR=jochen@chromium.org
==========

to

==========
Renaming Gnubby and RemoteSecurityKey files/classes/members

This change is a simple refactoring to rename the 'Gnubby' and
'RemoteSecurityKey' file/class names/comments/etc to be consistent.
I've chosen to use 'SecurityKey' as it is shorter that RemoteSecurityKey
(which was causing too many 80 char limit issues).  No functional
changes are expected as a result of this change.

Note: Not every instance of Gnubby or RemoteSecurityKey has been
changed.  The registry key used for toggling this functionality still
uses 'gnubby'.  I don't want to change that here.  Also, the process
used on the host machine is still called remote_security_key so classes
associated with that process were not renamed (neither were the IPC
messages used by it).

BUG=593736
TBR=jochen@chromium.org

Committed: https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516
Cr-Commit-Position: refs/heads/master@{#406435}
==========

[commit-bot: I haz the power, 2016-07-20 01:08:25]

Patchset 3 (id:??) landed as
https://crrev.com/281516541a3aa129b5a23c29cdfb926c99f3d516
Cr-Commit-Position: refs/heads/master@{#406435}

[hayato, 2016-07-20 01:29:21]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2167473003/ by hayato@chromium.org.

The reason for reverting is: Build break: 
https://build.chromium.org/p/chromium.mac/builders/Mac%20GYP%20%28dbg%29/buil....

[findit-for-me, 2016-07-20 01:43:24]

FYI: Findit try jobs (rerunning failed compile or tests) identified this CL
at revision 406435 as the culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[joedow, 2016-07-20 20:31:54]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2170563002/ by joedow@chromium.org.

The reason for reverting is: Broke GYP build bots..