base/synchronization/atomic_flag_unittest.cc - Issue 2162053006: Move EXPECT_DCHECK_DEATH from base/task_scheduler and use it in relevant base/ tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/synchronization/atomic_flag_unittest.cc

Issue 2162053006: Move EXPECT_DCHECK_DEATH from base/task_scheduler and use it in relevant base/ tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge up to r408965 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/synchronization/atomic_flag_unittest.cc

diff --git a/base/synchronization/atomic_flag_unittest.cc b/base/synchronization/atomic_flag_unittest.cc

index b0dfd47e4653970789739e24126946bd5c790a1f..c9b166aad4ddc917a43ba2ea15cab60cfe2dad21 100644

--- a/base/synchronization/atomic_flag_unittest.cc

+++ b/base/synchronization/atomic_flag_unittest.cc

@@ -8,20 +8,12 @@

#include "base/logging.h"

#include "base/single_thread_task_runner.h"

#include "base/synchronization/waitable_event.h"

+#include "base/test/gtest_util.h"

#include "base/threading/platform_thread.h"

#include "base/threading/thread.h"

#include "build/build_config.h"

#include "testing/gtest/include/gtest/gtest.h"

-// Death tests misbehave on Android.

-// TODO(fdoray): Remove this when https://codereview.chromium.org/2162053006

-// lands.

-#if DCHECK_IS_ON() && defined(GTEST_HAS_DEATH_TEST) && !defined(OS_ANDROID)

-#define EXPECT_DCHECK_DEATH(statement, regex) EXPECT_DEATH(statement, regex)

-#else

-#define EXPECT_DCHECK_DEATH(statement, regex)

-#endif

namespace base {

namespace {

« no previous file with comments | « base/metrics/sample_vector_unittest.cc ('k') | base/task_scheduler/priority_queue_unittest.cc » ('j') | no next file with comments »