Move EXPECT_DCHECK_DEATH from base/task_scheduler and use it in relevant base/ tests

base/synchronization/atomic_flag_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/synchronization/atomic_flag.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "base/synchronization/waitable_event.h"
+#include "base/test/gtest_util.h"
 #include "base/threading/platform_thread.h"
 #include "base/threading/thread.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
-// Death tests misbehave on Android.
-// TODO(fdoray): Remove this when https://codereview.chromium.org/2162053006
-// lands.
-#if DCHECK_IS_ON() && defined(GTEST_HAS_DEATH_TEST) && !defined(OS_ANDROID)
-#define EXPECT_DCHECK_DEATH(statement, regex) EXPECT_DEATH(statement, regex)
-#else
-#define EXPECT_DCHECK_DEATH(statement, regex)
-#endif
-
 namespace base {
 
 namespace {
 
 void ExpectSetFlagDeath(AtomicFlag* flag) {
   ASSERT_TRUE(flag);
   EXPECT_DCHECK_DEATH(flag->Set(), "");
 }
 
 void BusyWaitUntilFlagIsSet(AtomicFlag* flag) {
@@ skipping 43 matching lines @@
   // die on a DCHECK if Set() is called from other thread.
   ::testing::FLAGS_gtest_death_test_style = "threadsafe";
   Thread t("AtomicFlagTest.SetOnDifferentThreadDeathTest");
   ASSERT_TRUE(t.Start());
 
   AtomicFlag flag;
   t.task_runner()->PostTask(FROM_HERE, Bind(&ExpectSetFlagDeath, &flag));
 }
 
 }  // namespace base