Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2162033003: Include any text shadow bounds in SVG text cull rect. (Closed)

Created:
4 years, 5 months ago by wkorman
Modified:
4 years, 5 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include any text shadow bounds in SVG text cull rect. BUG=628414 Committed: https://crrev.com/378e044af89a3c3a75f83c60508c0c42a297bae1 Cr-Commit-Position: refs/heads/master@{#406612}

Patch Set 1 #

Patch Set 2 : Add test for text shadow cullrect. #

Patch Set 3 : Fix approximation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -30 lines) Patch
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 5 chunks +12 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp View 1 2 4 chunks +34 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
wkorman
Depends on and integrates https://codereview.chromium.org/2154143005 which is still in flight but about to land (again, ...
4 years, 5 months ago (2016-07-19 21:42:48 UTC) #2
chrishtr
lgtm
4 years, 5 months ago (2016-07-19 22:29:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162033003/1
4 years, 5 months ago (2016-07-19 22:30:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162033003/40001
4 years, 5 months ago (2016-07-20 01:05:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/265535)
4 years, 5 months ago (2016-07-20 02:15:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162033003/40001
4 years, 5 months ago (2016-07-20 16:37:50 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 17:59:58 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 18:02:12 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/378e044af89a3c3a75f83c60508c0c42a297bae1
Cr-Commit-Position: refs/heads/master@{#406612}

Powered by Google App Engine
This is Rietveld 408576698