Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 2154143005: Calculate correct cull rect for SVG inline text boxes. (Closed)

Created:
4 years, 5 months ago by wkorman
Modified:
4 years, 5 months ago
Reviewers:
pdr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Calculate correct cull rect for SVG inline text boxes. Reland of http://crrev.com/2151323004, now updated to allow for 8 pixels delta and using outsets fixing bug where we didn't move the expected bounding rects after expanding/contracting. Cull rects were larger than needed when text was selected. Identified while investigating test failure of: svg/text/text-selection-align-06-b.svg as part of http://crrev.com/2073563002 for crbug.com/616600, though fixing these did not actually fix any issues for that patch or bug. BUG=627233 TBR=pdr Committed: https://crrev.com/fcc8306cb32357373c4154f510a48fb869de6ec5 Cr-Commit-Position: refs/heads/master@{#406386}

Patch Set 1 #

Patch Set 2 : Use outsets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -3 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
A third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainterTest.cpp View 1 1 chunk +138 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2154143005/20001
4 years, 5 months ago (2016-07-19 20:14:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 21:38:38 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 21:38:39 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 21:42:20 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fcc8306cb32357373c4154f510a48fb869de6ec5
Cr-Commit-Position: refs/heads/master@{#406386}

Powered by Google App Engine
This is Rietveld 408576698