Add some initial histograms about subresource filtering.

Add some initial histograms about subresource filtering.

The following histograms are being added:
 - Record activation state on each document load.
 - Record whether the memory mapped rules were available on each document load.
 - Record the number of subresources evaluated/matched/disallowed per document
   load.

BUG=609747
Committed: https://crrev.com/446d07d43cff770c0a92873346334fd1149bff1a
Cr-Commit-Position: refs/heads/master@{#406561}

[engedy, 2016-07-19 09:42:50]

Description was changed from

==========
Add some initial histograms about subresource filtering.

The following histograms are being added:
 - Record activation state on each document load.
 - Record whether the memory mapped rules were available on each document load.
 - Record the number of subresources evaluated/matched/disallowed per document
   load.

BUG=609747
==========

to

==========
Add some initial histograms about subresource filtering.

The following histograms are being added:
 - Record activation state on each document load.
 - Record whether the memory mapped rules were available on each document load.
 - Record the number of subresources evaluated/matched/disallowed per document
   load.

BUG=609747
==========

[engedy, 2016-07-19 09:42:50]

engedy@chromium.org changed reviewers:
+ melandory@chromium.org, motek@chromium.org

[engedy, 2016-07-19 09:43:05]

The CQ bit was checked by engedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 09:43:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[engedy, 2016-07-19 09:45:10]

Tanja, please review the whole CL.

Marcin, please review histograms. In particular, what's the best way to record
scoped enumerations?

[commit-bot: I haz the power, 2016-07-19 09:52:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 09:52:35]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[engedy, 2016-07-19 09:56:06]

The CQ bit was checked by engedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 09:56:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 11:02:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 11:02:01]

Dry run: This issue passed the CQ dry run.

[melandory, 2016-07-19 12:19:12]

On 2016/07/19 09:45:10, engedy wrote:
> Tanja, please review the whole CL.
> 
> Marcin, please review histograms. In particular, what's the best way to record
> scoped enumerations?

lgtm

[motek., 2016-07-19 21:54:02]

Looks pretty much fine. I am not sure what you mean by 'scoped enumeration' but
we don't have any specific tools for treating 'conditional' histograms (that
something is only registered when something else had a particular state). 

One of practices for counting expressing walking over a collection of states is
to have an enum histogram where bins (A, B, C) correspond to distinct states ,
with transition say A->B->C. Then you increase count of an appropriate bin as a
particular state is reached. 

Again, analysis tools don't support that (although we did consider that). 

lgtm

[engedy, 2016-07-19 23:19:44]

Thanks for taking a look!

By 'scoped enumeration' I was only referring to the enum class ActivationState.
I was wondering if there is a better way than to have all those static_casts in
the histogram macro invocation.

[engedy, 2016-07-20 10:42:24]

The CQ bit was checked by engedy@chromium.org

[engedy, 2016-07-20 10:42:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
melandory@chromium.org
Link to the patchset: https://codereview.chromium.org/2161963002/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-20 10:42:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 10:42:41]

This CL has an open dependency (Issue 2158833002 Patch 140001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[engedy, 2016-07-20 10:45:11]

The CQ bit was checked by engedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 10:45:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 12:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 12:51:33]

Dry run: This issue passed the CQ dry run.

[engedy, 2016-07-20 13:02:30]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2016-07-20 13:03:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 13:12:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 13:12:28]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[engedy, 2016-07-20 13:15:23]

engedy@chromium.org changed reviewers:
+ jwd@chromium.org

[engedy, 2016-07-20 13:15:24]

@Jesse, could you please review histograms.xml?

[jwd, 2016-07-20 14:53:24]

lgtm

[engedy, 2016-07-20 15:11:41]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2016-07-20 15:12:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 15:19:23]

Description was changed from

==========
Add some initial histograms about subresource filtering.

The following histograms are being added:
 - Record activation state on each document load.
 - Record whether the memory mapped rules were available on each document load.
 - Record the number of subresources evaluated/matched/disallowed per document
   load.

BUG=609747
==========

to

==========
Add some initial histograms about subresource filtering.

The following histograms are being added:
 - Record activation state on each document load.
 - Record whether the memory mapped rules were available on each document load.
 - Record the number of subresources evaluated/matched/disallowed per document
   load.

BUG=609747
==========

[commit-bot: I haz the power, 2016-07-20 15:19:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-20 15:19:28]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 15:21:17]

Description was changed from

==========
Add some initial histograms about subresource filtering.

The following histograms are being added:
 - Record activation state on each document load.
 - Record whether the memory mapped rules were available on each document load.
 - Record the number of subresources evaluated/matched/disallowed per document
   load.

BUG=609747
==========

to

==========
Add some initial histograms about subresource filtering.

The following histograms are being added:
 - Record activation state on each document load.
 - Record whether the memory mapped rules were available on each document load.
 - Record the number of subresources evaluated/matched/disallowed per document
   load.

BUG=609747

Committed: https://crrev.com/446d07d43cff770c0a92873346334fd1149bff1a
Cr-Commit-Position: refs/heads/master@{#406561}
==========

[commit-bot: I haz the power, 2016-07-20 15:21:19]

Patchset 4 (id:??) landed as
https://crrev.com/446d07d43cff770c0a92873346334fd1149bff1a
Cr-Commit-Position: refs/heads/master@{#406561}